[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...

2018-01-24 Thread neilalex
Github user neilalex commented on the issue: https://github.com/apache/spark/pull/20352 @felixcheung @yanboliang @shivaram thank you for your guidance! --- - To unsubscribe, e-mail:

[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...

2018-01-23 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20352 merged to master/2.3. we could revisit migration guide if necessary. thanks! --- - To unsubscribe, e-mail:

[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...

2018-01-23 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20352 That looks good. Thanks! We work together on this fix so I’m pretty confident about this change. On a side note assuming we push this to 2.3 should we add the behavior change to the

[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...

2018-01-22 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/20352 Thanks @neilalex - Change LGTM. Lets also see if @felixcheung has any comments. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20352 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86500/ Test PASSed. ---

[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20352 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20352 **[Test build #86500 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86500/testReport)** for PR 20352 at commit

[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...

2018-01-22 Thread neilalex
Github user neilalex commented on the issue: https://github.com/apache/spark/pull/20352 @shivaram alright, should be good with the tests now -- let me know how it seems --- - To unsubscribe, e-mail:

[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20352 **[Test build #86500 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86500/testReport)** for PR 20352 at commit

[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20352 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20352 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86494/ Test PASSed. ---

[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20352 **[Test build #86494 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86494/testReport)** for PR 20352 at commit

[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...

2018-01-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20352 **[Test build #86494 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86494/testReport)** for PR 20352 at commit

[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...

2018-01-22 Thread neilalex
Github user neilalex commented on the issue: https://github.com/apache/spark/pull/20352 sure --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...

2018-01-22 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/20352 @neilalex Can you add the code snippet in the PR description as a new test case ? That way we will ensure this behavior is tested going forward ---

[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...

2018-01-22 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/20352 Jenkins, ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20352 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...

2018-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20352 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional