[GitHub] spark issue #20367: [SPARK-23166][ML] Add maxDF Parameter to CountVectorizer

2018-01-28 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/20367 Thanks @ymazari this is a nice improvement! merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #20367: [SPARK-23166][ML] Add maxDF Parameter to CountVectorizer

2018-01-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20367 **[Test build #4083 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4083/testReport)** for PR 20367 at commit

[GitHub] spark issue #20367: [SPARK-23166][ML] Add maxDF Parameter to CountVectorizer

2018-01-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20367 **[Test build #4083 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4083/testReport)** for PR 20367 at commit

[GitHub] spark issue #20367: [SPARK-23166][ML] Add maxDF Parameter to CountVectorizer

2018-01-27 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/20367 LGTM, thanks --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20367: [SPARK-23166][ML] Add maxDF Parameter to CountVectorizer

2018-01-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20367 **[Test build #4077 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4077/testReport)** for PR 20367 at commit

[GitHub] spark issue #20367: [SPARK-23166][ML] Add maxDF Parameter to CountVectorizer

2018-01-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20367 **[Test build #4077 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4077/testReport)** for PR 20367 at commit

[GitHub] spark issue #20367: [SPARK-23166][ML] Add maxDF Parameter to CountVectorizer

2018-01-24 Thread ymazari
Github user ymazari commented on the issue: https://github.com/apache/spark/pull/20367 @srowen It seems that this PR needs Admin approval. Could you please help getting it to the next step? Thanks. --- - To

[GitHub] spark issue #20367: [SPARK-23166][ML] Add maxDF Parameter to CountVectorizer

2018-01-23 Thread ymazari
Github user ymazari commented on the issue: https://github.com/apache/spark/pull/20367 @mgaido91 I closed the previous PR and opened this one. I am answering your comments here. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20367: [SPARK-23166][ML] Add maxDF Parameter to CountVectorizer

2018-01-23 Thread ymazari
Github user ymazari commented on the issue: https://github.com/apache/spark/pull/20367 @hhbyyh, @MLnick, @jkbradley could you please help reviewing this? Thanks. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20367: [SPARK-23166][ML] Add maxDF Parameter to CountVectorizer

2018-01-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20367 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20367: [SPARK-23166][ML] Add maxDF Parameter to CountVectorizer

2018-01-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20367 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional