Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/20373
Great, thanks @HyukjinKwon! The 0.4.3 code matches this exactly, so I will
just adjust the descriptions.
---
-
To
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20373
@BryanCutler, I just released 0.4.3 -
https://github.com/cloudpipe/cloudpickle/releases/tag/v0.4.3. Would you mind if
I ask to fix PR and JIRA accordingly?
---
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/20373
Sounds good! No rush, I'll keep an eye out for the release
---
-
To unsubscribe, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20373
Yup, now the codes of branch "0.4.x" in cloudpickle is the same with the
current PR. Was thinking of letting you know after 0.4.3. Please give me few
days ... :-).
---
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/20373
@HyukjinKwon would it be good to update this PR to match the upcoming 4.3
release you are working on? If the code is the same, then just updating the
title/description so it is clear
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20373
FYI, I am trying to make a minor release of cloudpickle to match with this
to deduplicate our efforts. We put many efforts to find and backport bug fixes
here. :-).
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20373
To me, yup.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/20373
this is targeting master, right?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20373
Will merge this one in few days if there's no more comments.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20373
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20373
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87047/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20373
**[Test build #87047 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87047/testReport)**
for PR 20373 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20373
**[Test build #87047 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87047/testReport)**
for PR 20373 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20373
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/573/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20373
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20373
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20373
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86885/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20373
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20373
**[Test build #86885 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86885/testReport)**
for PR 20373 at commit
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/20373
I also ran the cloudpickle_tests again after adding cloudpickle#140 (and
test) and it is still passing
---
-
To
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20373
**[Test build #86885 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86885/testReport)**
for PR 20373 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20373
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/439/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20373
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/20373
Yeah the formatting changes will just make it more complicated for the next
update, so they should probably not be included now. cloudpickle#140 looks
pretty clean so I'll put that in.
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20373
Ah, yup. I am okay with including it. Wanted to double check. Seems a small
clean bug fix.
---
-
To unsubscribe, e-mail:
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/20373
@HyukjinKwon Yes, I meant to port it too. I agree with matching it to
v0.4.2 as same as we can, so I don't think we should include formatting one but
bug fixes.
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20373
Hm .. I was thinking we should focus on matching it to v0.4.2 as same as we
can. Few bug links I and @ueshin found looked regressions comparing to our copy
so I suggested to include them here
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20373
@ueshin, is https://github.com/cloudpipe/cloudpickle/pull/140 a regression
comparing to our cloudcpikle copy, or do you suggest to port it too as it's a
simple and clean bug fix? Seems the same
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/20373
>Wait .. @BryanCutler, did you port the formatting one here ..? I was
thinking we should match it to v0.4.2 as same as possible to reduce the diff.
Yes I added that here as well because
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/20373
What about https://github.com/cloudpipe/cloudpickle/pull/140?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20373
**[Test build #86852 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86852/testReport)**
for PR 20373 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20373
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86852/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20373
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20373
Wait .. @BryanCutler, did you port the formatting one here ..? I was
thinking we should match it to v0.4.2 as same as possible to reduce the diff.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20373
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20373
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/408/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20373
**[Test build #86852 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86852/testReport)**
for PR 20373 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20373
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86786/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20373
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20373
**[Test build #86786 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86786/testReport)**
for PR 20373 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20373
Yup, I double checked that ahead by manual port. I think that failure might
be related with environment which I think is the same I met. If we run the
comments as written in the travis, seems
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/20373
I ran cloudpickle_tests locally and verified that the tests pass with the 2
backported fixes applied. I did get an unrelated test failure but that
happened even before added the fixes and
42 matches
Mail list logo
