Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20385
LGTM
@atallahhezbor Could you submit another PR to address the comment from
@liufengdb ?
This fix is nice to have in Spark 2.3. Let merge this now.
Thanks! Merged to
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20385
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20385
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86887/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20385
**[Test build #86887 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86887/testReport)**
for PR 20385 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20385
**[Test build #86887 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86887/testReport)**
for PR 20385 at commit
Github user liufengdb commented on the issue:
https://github.com/apache/spark/pull/20385
Actually, one more thing, do you need to consider the UDT as one attribute
of a structured type?
https://github.com/apache/spark/pull/20385/files#diff-842e3447fc453de26c706db1cac8f2c4L467
---
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20385
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user liufengdb commented on the issue:
https://github.com/apache/spark/pull/20385
LGTM!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20385
@atallahhezbor Yeah! Please help us improve the test coverage. We do not
have a clear way to test the functionality in `SparkExecuteStatementOperation`
Adding unit test cases for
Github user atallahhezbor commented on the issue:
https://github.com/apache/spark/pull/20385
@liufengdb @gatorsmile I'm happy to write a unit test if you require it.
Though as I mentioned before, I did not see a clear way of testing the
functionality in
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20385
The unit test cases are needed for `HiveUtils.toHiveString`.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20385
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86597/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20385
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20385
**[Test build #86597 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86597/testReport)**
for PR 20385 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20385
**[Test build #86597 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86597/testReport)**
for PR 20385 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/20385
Jenkins test this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20385
cc @liufengdb
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20385
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20385
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
19 matches
Mail list logo
