Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/20410
yes, if we go on with that, I can close this @HyukjinKwon , thanks.
---
-
To unsubscribe, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20410
So .. #18982 takes over this and I think SPARK-23234 is a duplicate of
SPARK-21685?
---
-
To unsubscribe, e-mail:
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/20410
@BryanCutler I think it would be an OK assumption to make that the default
values should be the same between Python and Scala provided we maybe added it
to the params docs? What does @HyukjinKwon /
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/20410
Thanks @mgaido91 , #18982 had been sitting for so long, I forgot it was
really the same issue as here! As for the defaults, I think the assumption that
python and scala have the same value is
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/20410
@BryanCutler yes, I see it only now sorry. I am fine either with your
change and this one. Personally, I think that it is not a good idea to transfer
defaults, because it means we might have
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/20410
@mgaido91 , this is actually the same fix as in #18982 only that also
transfers the default values to Java, which I still think is a good idea
because if users define their own models, it
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/20410
kindly ping @BryanCutler @MLnick @zhengruifeng
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/20410
any more comments on this?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/20410
I think that the problem is not SPARK-22797. The problem is that before
this PR, the Python API considers as Defined but not Set all the parameters
with a default value, while the Scala/Java class
Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/20410
I reverted #19892 in master (f5911d4894700eb48f794133cbd363bf3b7c8c8e) /
branch-2.3 (a8a3e9b7cf7b9346c43cfbbf7b26fd2fd28dd521), so that other test runs
can be unblocked.
---
Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/20410
I think this is somewhat related to #15113
cc @BryanCutler
---
-
To unsubscribe, e-mail:
Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/20410
We should just revert SPARK-22797 for now to unblock others.
SPARK-22799 itself is not the cause per se (it passed tests) but after it
was merged SPARK-22797 causes the failure.
---
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/20410
CC @zhengruifeng @MLnick
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20410
**[Test build #86717 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86717/testReport)**
for PR 20410 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20410
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86717/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20410
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20410
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/294/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20410
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20410
**[Test build #86717 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86717/testReport)**
for PR 20410 at commit
19 matches
Mail list logo
