Github user squito commented on the issue:
https://github.com/apache/spark/pull/20422
merged to master.
thanks @yaooqinn for doing and updating the tests too
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20422
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86959/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20422
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20422
**[Test build #86959 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86959/testReport)**
for PR 20422 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20422
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86958/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20422
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20422
**[Test build #86958 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86958/testReport)**
for PR 20422 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20422
**[Test build #86959 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86959/testReport)**
for PR 20422 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20422
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20422
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/501/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20422
**[Test build #86958 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86958/testReport)**
for PR 20422 at commit
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/20422
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20422
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20422
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86907/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20422
**[Test build #86907 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86907/testReport)**
for PR 20422 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20422
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86906/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20422
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20422
**[Test build #86906 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86906/testReport)**
for PR 20422 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20422
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86905/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20422
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20422
**[Test build #86905 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86905/testReport)**
for PR 20422 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20422
**[Test build #86907 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86907/testReport)**
for PR 20422 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20422
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20422
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/458/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20422
**[Test build #86906 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86906/testReport)**
for PR 20422 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20422
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20422
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/457/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20422
**[Test build #86905 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86905/testReport)**
for PR 20422 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20422
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/456/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20422
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user squito commented on the issue:
https://github.com/apache/spark/pull/20422
@jerryshao are you ok with making this change? I think our original
comments corssed paths as I was taking a closer look
---
-
Github user yaooqinn commented on the issue:
https://github.com/apache/spark/pull/20422
@squito add a test for index file. plz check it again, thanks.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20422
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86858/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20422
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20422
**[Test build #86858 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86858/testReport)**
for PR 20422 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20422
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20422
**[Test build #86858 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86858/testReport)**
for PR 20422 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20422
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/414/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20422
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86831/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20422
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20422
**[Test build #86831 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86831/testReport)**
for PR 20422 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20422
**[Test build #86831 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86831/testReport)**
for PR 20422 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20422
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/391/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20422
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user yaooqinn commented on the issue:
https://github.com/apache/spark/pull/20422
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20422
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20422
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86806/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20422
**[Test build #86806 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86806/testReport)**
for PR 20422 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20422
**[Test build #86806 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86806/testReport)**
for PR 20422 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20422
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20422
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/370/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20422
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20422
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86792/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20422
**[Test build #86792 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86792/testReport)**
for PR 20422 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20422
**[Test build #86792 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86792/testReport)**
for PR 20422 at commit
Github user squito commented on the issue:
https://github.com/apache/spark/pull/20422
Jenkins, ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/20422
I agree with @squito , unless there's a bug in it, it is risky and
unnecessary to change the logic in this critical path.
---
Github user yaooqinn commented on the issue:
https://github.com/apache/spark/pull/20422
thanks guys for reviewing. yes, this is just a minor improvement which I
guess code here seem not very logical when I was trying to do some
optimizations for my customer's heavy shuffle case. If
Github user squito commented on the issue:
https://github.com/apache/spark/pull/20422
thanks for taking a look at this @yaooqinn . To clarify -- there is no bug
you are trying to fix here, is there? Its just an optimization? From a quick
glance I think the change seems correct ...
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20422
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86768/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20422
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20422
**[Test build #86768 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86768/testReport)**
for PR 20422 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20422
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/334/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20422
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20422
**[Test build #86768 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86768/testReport)**
for PR 20422 at commit
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/20422
I think it is necessary to add unit test to verify the changes.
---
-
To unsubscribe, e-mail:
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/20422
Is this just trying to reuse a file that should have been cleaned up after
prior failure? If so is that possible as a more direct solution? I wonder if
there aren't corner cases here where the file
67 matches
Mail list logo
