Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20428
Will submit a new PR to 2.3
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20428
Let me manually push it to 2.3. Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20428
Yes. We need to backport it to 2.3
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20428
@gatorsmile shall we backport it to 2.3? excluding the `GROUPED AGG`.
---
-
To unsubscribe, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20428
Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20428
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86804/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20428
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20428
**[Test build #86804 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86804/testReport)**
for PR 20428 at commit
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/20428
LGTM.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20428
**[Test build #86804 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86804/testReport)**
for PR 20428 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20428
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20428
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/368/
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/20428
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20428
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20428
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86798/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20428
**[Test build #86798 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86798/testReport)**
for PR 20428 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20428
Let's also update PR description too.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20428
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/362/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20428
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20428
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20428
**[Test build #86798 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86798/testReport)**
for PR 20428 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20428
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86794/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20428
**[Test build #86794 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86794/testReport)**
for PR 20428 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20428
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20428
**[Test build #86794 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86794/testReport)**
for PR 20428 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20428
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/358/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20428
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20428
+1 on `GROUPED AGG` too, we may add new UDF type when we support partial
aggregate.
---
-
To unsubscribe, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20428
+1 on `GROUPED AGG` to me too, just to be clear.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user sameeragarwal commented on the issue:
https://github.com/apache/spark/pull/20428
+1 on `GROUPED AGG` as well
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20428
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20428
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86784/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20428
**[Test build #86784 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86784/testReport)**
for PR 20428 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20428
First two changes looks good. The last one, maybe `PANDAS GROUP AGG UDF` ->
`GROUPED AGG PANDAS UDF`?
---
-
To unsubscribe,
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20428
Yup, fortunately(?) we are free to rename `SQL_PANDAS_GROUP_AGG_UDF` within
2.4.0 currently but I believe here is a good place to decide based on what I
got so far. The proposal seems fine to
Github user icexelloss commented on the issue:
https://github.com/apache/spark/pull/20428
* `PANDAS SCALAR UDF` -> `SCALAR PANDAS UDF`
This doesn't really change the API so +1
* `PANDAS GROUP MAP UDF` -> `GROUPED MAP PANDAS UDF`
The API changes from
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20428
Had an offline discussion with @sameeragarwal and @cloud-fan . To be
consistent with the other APIs, we would propose to make the above changes.
The major question is about the current
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20428
**[Test build #86784 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86784/testReport)**
for PR 20428 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20428
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/351/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20428
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
40 matches
Mail list logo
