Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20455
thanks, merging to master/2.3!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/20455
LGTM.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20455
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20455
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86941/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20455
**[Test build #86941 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86941/testReport)**
for PR 20455 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20455
**[Test build #86941 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86941/testReport)**
for PR 20455 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20455
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20455
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20455
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86935/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20455
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20455
**[Test build #86935 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86935/testReport)**
for PR 20455 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20455
**[Test build #86935 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86935/testReport)**
for PR 20455 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20455
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/483/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20455
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20455
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86926/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20455
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20455
**[Test build #86926 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86926/testReport)**
for PR 20455 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20455
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86923/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20455
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20455
**[Test build #86923 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86923/testReport)**
for PR 20455 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20455
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20455
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86921/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20455
**[Test build #86921 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86921/testReport)**
for PR 20455 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20455
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86918/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20455
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20455
**[Test build #86918 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86918/testReport)**
for PR 20455 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20455
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/475/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20455
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20455
**[Test build #86926 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86926/testReport)**
for PR 20455 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20455
**[Test build #86923 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86923/testReport)**
for PR 20455 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20455
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/472/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20455
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20455
@ueshin Yes, missing it. Thanks. I'll add it.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/20455
We also need to add `if (isNullAt(rowId)) return null;` to
`WritableColumnVector.getMap()`?
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20455
**[Test build #86921 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86921/testReport)**
for PR 20455 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20455
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20455
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/470/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20455
**[Test build #86918 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86918/testReport)**
for PR 20455 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20455
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/467/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20455
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20455
Since the map support is added, I'll do related change later.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20455
LGTM for this behavior and comments.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20455
BTW we should also update `ColumnarBatchSuite` for the "return null"
behavior
---
-
To unsubscribe, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20455
LGTM so far, one thing I wanna add is to also document the behavior of
accessing null primitive values, e.g. `getInt`. We can say that the return
value is undefined and can be anything, if that
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/20455
LGTM so far. Let's wait for map type support.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20455
cc @cloud-fan @ueshin @kiszk
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20455
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20455
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86878/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20455
**[Test build #86878 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86878/testReport)**
for PR 20455 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20455
Once map support is added later, we should also document `getMap`'s
behavior.
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20455
**[Test build #86878 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86878/testReport)**
for PR 20455 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20455
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/434/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20455
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
53 matches
Mail list logo
