[GitHub] spark issue #20503: [SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviour for R...

Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20503 ping @ashashwat to update --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20503: [SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviour for R...

Github user holdenk commented on the issue: https://github.com/apache/spark/pull/20503 Awesome, thanks. Let me know if I can help :) --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20503: [SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviour for R...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20503 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98110/ Test PASSed. ---

[GitHub] spark issue #20503: [SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviour for R...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20503 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20503: [SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviour for R...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20503 **[Test build #98110 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98110/testReport)** for PR 20503 at commit

[GitHub] spark issue #20503: [SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviour for R...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20503 **[Test build #98110 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98110/testReport)** for PR 20503 at commit

[GitHub] spark issue #20503: [SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviour for R...

Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20503 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20503: [SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviour for R...

Github user ashashwat commented on the issue: https://github.com/apache/spark/pull/20503 @holdenk I am on it. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20503: [SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviour for R...

Github user holdenk commented on the issue: https://github.com/apache/spark/pull/20503 Jenkins ok to test. Gentle ping again to @ashashwat - are you still interested in this PR? --- - To unsubscribe, e-mail:

[GitHub] spark issue #20503: [SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviour for R...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20503 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20503: [SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviour for R...

Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20503 Looks good otherwise. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20503: [SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviour for R...

Github user holdenk commented on the issue: https://github.com/apache/spark/pull/20503 Gentle ping again to @ashashwat . Also @HyukjinKwon what are your opinions on the test coverage? --- - To unsubscribe, e-mail:

[GitHub] spark issue #20503: [SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviour for R...

Github user holdenk commented on the issue: https://github.com/apache/spark/pull/20503 Gentle ping --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20503: [SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviour for R...

Github user holdenk commented on the issue: https://github.com/apache/spark/pull/20503 I _think_ this could be good to backport into 2.4 assuming the current RC fails if @ashashwat has the chance to update it and no one sees any issues with including this in a backport to that

[GitHub] spark issue #20503: [SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviour for R...

Github user holdenk commented on the issue: https://github.com/apache/spark/pull/20503 Sure let's add a test with a unicode string to it if there's concern about that and make sure the existing repr with named fields is covered the same test case since I don't see an existing

[GitHub] spark issue #20503: [SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviour for R...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20503 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91594/ Test PASSed. ---

[GitHub] spark issue #20503: [SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviour for R...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20503 **[Test build #91594 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91594/testReport)** for PR 20503 at commit

[GitHub] spark issue #20503: [SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviour for R...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20503 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20503: [SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviour for R...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20503 **[Test build #91594 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91594/testReport)** for PR 20503 at commit

[GitHub] spark issue #20503: [SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviour for R...

Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20503 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20503: [SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviour for R...

Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20503 we still need to fix this, right? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20503: [SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviour for R...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20503 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20503: [SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviour for R...

Github user ashashwat commented on the issue: https://github.com/apache/spark/pull/20503 @HyukjinKwon Should I add more tests covering Unicode? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #20503: [SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviour for R...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20503 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20503: [SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviour for R...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20503 **[Test build #87143 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87143/testReport)** for PR 20503 at commit

[GitHub] spark issue #20503: [SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviour for R...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20503 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87143/ Test PASSed. ---

[GitHub] spark issue #20503: [SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviour for R...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20503 **[Test build #87143 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87143/testReport)** for PR 20503 at commit

[GitHub] spark issue #20503: [SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviour for R...

Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20503 Jenkins, ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20503: [SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviour for R...

Github user ashashwat commented on the issue: https://github.com/apache/spark/pull/20503 @HyukjinKwon `return "" % ", ".join("%s" % (fields) for fields in self)` takes care of everything. ``` >>> Row ("aa", 11) >>> Row (u"아", 11)

[GitHub] spark issue #20503: [SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviour for R...

Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20503 Check if it's `unicode` and convert, etc. might also work .. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20503: [SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviour for R...

Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20503 `unicode(fields).encode("utf8")`: in this case, we will try to decode it by system default encoding first and then encode it by udf-8 if the input is `str` (bytes). So, for example, I think

[GitHub] spark issue #20503: [SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviour for R...

Github user ashashwat commented on the issue: https://github.com/apache/spark/pull/20503 @HyukjinKwon Here is what I tried: ``` # Code: return "" % ", ".join(fields.encode("utf8") for fields in self) >>> Row (u"아", "11") # Fails for

[GitHub] spark issue #20503: [SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviour for R...

Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20503 I think it still makes sense to produce a repr anyway because we successfully can create the instance for now but .. let me take a closer look within few days for sure. ---

[GitHub] spark issue #20503: [SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviour for R...

Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20503 I meant things like this: ```python >>> from pyspark.sql import Row >>> RowClass = Row(1) >>> RowClass("a") Row(1='a') ``` ```python >>>

[GitHub] spark issue #20503: [SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviour for R...

Github user ashashwat commented on the issue: https://github.com/apache/spark/pull/20503 @HyukjinKwon Do you mean something like `Row (a=1, b=2, c=3)` or `Row (1="Alice", 2=11)`? Former works fine, latter fails with `SyntaxError: keyword can't be an expression`. ---

[GitHub] spark issue #20503: [SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviour for R...

Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20503 BTW, does non-string field names work in this namedtuple way? --- - To unsubscribe, e-mail:

[GitHub] spark issue #20503: [SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviour for R...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20503 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20503: [SPARK-23299][SQL][PYSPARK] Fix __repr__ behaviour for R...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20503 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional