Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/20685
Thanks for merging !
@cloud-fan @squito @zsxwing @Ngone51
---
-
To unsubscribe, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20685
thanks, merging to master/2.3!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user squito commented on the issue:
https://github.com/apache/spark/pull/20685
lgtm
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user squito commented on the issue:
https://github.com/apache/spark/pull/20685
I agree with @cloud-fan .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20685
yea very likely, but I'm not 100% sure. How about we merge this one first
to fix the mistake for local shuffle blocks, and then think about whether or
not we should remove this corruption check?
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/20685
I think #20179 probably already fixed the data corruption issue.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20685
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88033/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20685
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20685
**[Test build #88033 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88033/testReport)**
for PR 20685 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20685
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/20685
@cloud-fan @squito
Thanks a lot !
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20685
sounds reasonable. The purpose of this corruption check is to fail fast to
retry the stage(re-shuffle), so disk corruption should also be counted.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20685
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1342/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20685
**[Test build #88033 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88033/testReport)**
for PR 20685 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20685
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user squito commented on the issue:
https://github.com/apache/spark/pull/20685
it'll also help with disk corruption ... from the stack traces in
SPARK-4105 you can't really tell what the source of the problem is. it'll be
pretty hard to determine what the source of corruption
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20685
From what I've seen in https://github.com/apache/spark/pull/15923 , this
corruption check is mostly to detect network failures, so seems like we don't
need this check for local blocks at all.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20685
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20685
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88003/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20685
**[Test build #88003 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88003/testReport)**
for PR 20685 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20685
**[Test build #88003 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88003/testReport)**
for PR 20685 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20685
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20685
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1316/
Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/20685
@squito @cloud-fan
Thanks you so much for reviewing. I refined accordingly. Please take
another look when you have time.
---
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20685
We should update the doc of `SuccessFetchResult#size`, currently it's
saying `estimated size of the block, used to calculate bytesInFlight.`
---
Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/20685
cc @cloud-fan @jiangxb1987
Could you please help take a look.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20685
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20685
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87807/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20685
**[Test build #87807 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87807/testReport)**
for PR 20685 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20685
**[Test build #87807 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87807/testReport)**
for PR 20685 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20685
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20685
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1171/
Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/20685
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/20685
The failed test is not relatedï¼ I can pass in my local
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20685
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87770/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20685
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20685
**[Test build #87770 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87770/testReport)**
for PR 20685 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20685
**[Test build #87770 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87770/testReport)**
for PR 20685 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20685
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1142/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20685
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/20685
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20685
**[Test build #87755 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87755/testReport)**
for PR 20685 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20685
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87755/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20685
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20685
**[Test build #87755 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87755/testReport)**
for PR 20685 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20685
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1132/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20685
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/20685
Jenkins, retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20685
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87741/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20685
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20685
**[Test build #87741 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87741/testReport)**
for PR 20685 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20685
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20685
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1123/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20685
**[Test build #87741 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87741/testReport)**
for PR 20685 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20685
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20685
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87714/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20685
**[Test build #87714 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87714/testReport)**
for PR 20685 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20685
**[Test build #87714 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87714/testReport)**
for PR 20685 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20685
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1099/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20685
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/20685
Jenkins, test this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
61 matches
Mail list logo
