Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20687
Will submit a separate PR for tests only.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20687
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20687
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20687
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88391/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20687
**[Test build #88391 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88391/testReport)**
for PR 20687 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20687
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1619/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20687
**[Test build #88391 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88391/testReport)**
for PR 20687 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20687
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user henryr commented on the issue:
https://github.com/apache/spark/pull/20687
@gatorsmile ok, I think the coverage right now is a reasonable start - the
other test cases I can think of would act more like they're exercising the
expression-walking code, not the actual
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20687
@henryr Please try to add the test cases that matter in your opinion. I
will also submit a follow-up PR to add more test cases after this PR is merged.
---
Github user henryr commented on the issue:
https://github.com/apache/spark/pull/20687
@gatorsmile thank you for the reviews! Are there specific test cases you'd
like to see? I've checked correlated and uncorrelated subqueries, various
flavours of join, aggregates with HAVING clauses,
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20687
@henryr Thanks for your great work!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20687
The fix looks good to me, but the test coverage is not enough.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20687
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88280/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20687
**[Test build #88280 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88280/testReport)**
for PR 20687 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20687
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20687
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1542/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20687
**[Test build #88280 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88280/testReport)**
for PR 20687 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20687
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20687
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20687
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88135/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20687
**[Test build #88135 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88135/testReport)**
for PR 20687 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20687
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1435/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20687
**[Test build #88135 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88135/testReport)**
for PR 20687 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20687
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20687
I didn't retrigger Jenkins due to the existing comment.
Overall, the PR looks reasonable to me. I look forward to see the follow-up
issue, SPARK-23634.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20687
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88056/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20687
**[Test build #88056 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88056/testReport)**
for PR 20687 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20687
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1362/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20687
**[Test build #88056 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88056/testReport)**
for PR 20687 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20687
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20687
@dongjoon-hyun Have you finished the review?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20687
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20687
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88035/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20687
**[Test build #88035 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88035/testReport)**
for PR 20687 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20687
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1344/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20687
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20687
**[Test build #88035 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88035/testReport)**
for PR 20687 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20687
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user henryr commented on the issue:
https://github.com/apache/spark/pull/20687
This failing because of SPARK-23606, which seems unrelated (I haven't been
able to trigger it in local builds, at least).
---
-
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20687
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20687
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88024/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20687
**[Test build #88024 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88024/testReport)**
for PR 20687 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20687
**[Test build #88024 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88024/testReport)**
for PR 20687 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20687
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1331/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20687
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user henryr commented on the issue:
https://github.com/apache/spark/pull/20687
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20687
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87971/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20687
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20687
**[Test build #87971 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87971/testReport)**
for PR 20687 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20687
**[Test build #87971 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87971/testReport)**
for PR 20687 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20687
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1286/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20687
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
53 matches
Mail list logo
