Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20756
I'm not sure if this setter is always for Initialization of bean's
property. Will it be possibly used to update the property with a null value? If
no, I think skipping is safe.
---
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20756
Yes that would effectively be the same.
Do you think we should always call setters for reference types?
---
-
To
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20756
We don't invoke the setter if the input is null, sounds like we simply skip
calling the setter if the input is null?
---
-
To
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20756
I think the semantic should be that we do not invoke the setter if the
input is null.
---
-
To unsubscribe, e-mail:
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20756
@hvanhovell Looks like we have tests using null as value for setters. So
the added null check fails.
---
-
To unsubscribe,
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20756
@viirya I thought it passed tests, but your last change is causing errors.
I am going to revert this for now. Can you reopen? Sorry about this.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88936/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20756
**[Test build #88936 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88936/testReport)**
for PR 20756 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2000/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20756
**[Test build #88936 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88936/testReport)**
for PR 20756 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20756
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88931/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20756
**[Test build #88931 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88931/testReport)**
for PR 20756 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1996/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20756
**[Test build #88931 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88931/testReport)**
for PR 20756 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20756
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88927/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88929/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20756
**[Test build #88929 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88929/testReport)**
for PR 20756 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20756
**[Test build #88927 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88927/testReport)**
for PR 20756 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20756
**[Test build #88929 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88929/testReport)**
for PR 20756 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1994/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1992/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20756
**[Test build #88927 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88927/testReport)**
for PR 20756 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88623/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20756
**[Test build #88623 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88623/testReport)**
for PR 20756 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20756
**[Test build #88623 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88623/testReport)**
for PR 20756 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1781/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20756
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88618/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20756
**[Test build #88618 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88618/testReport)**
for PR 20756 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20756
**[Test build #88618 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88618/testReport)**
for PR 20756 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1775/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88118/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20756
**[Test build #88118 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88118/testReport)**
for PR 20756 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1423/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20756
**[Test build #88118 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88118/testReport)**
for PR 20756 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20756
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88113/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20756
**[Test build #88113 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88113/testReport)**
for PR 20756 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20756
**[Test build #88113 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88113/testReport)**
for PR 20756 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1419/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88092/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20756
**[Test build #88092 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88092/testReport)**
for PR 20756 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20756
**[Test build #88092 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88092/testReport)**
for PR 20756 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1398/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88080/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20756
**[Test build #88080 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88080/testReport)**
for PR 20756 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1386/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20756
**[Test build #88080 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88080/testReport)**
for PR 20756 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88073/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20756
**[Test build #88073 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88073/testReport)**
for PR 20756 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88074/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20756
**[Test build #88074 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88074/testReport)**
for PR 20756 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20756
LGTM except one minor comment
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20756
also cc @kiszk @maropu
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20756
**[Test build #88074 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88074/testReport)**
for PR 20756 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1380/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20756
**[Test build #88073 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88073/testReport)**
for PR 20756 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1379/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88044/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20756
**[Test build #88044 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88044/testReport)**
for PR 20756 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20756
**[Test build #88044 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88044/testReport)**
for PR 20756 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1350/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88034/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88032/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20756
**[Test build #88034 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88034/testReport)**
for PR 20756 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20756
**[Test build #88032 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88032/testReport)**
for PR 20756 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1343/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20756
**[Test build #88034 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88034/testReport)**
for PR 20756 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20756
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
1 - 100 of 104 matches
Mail list logo
