Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20779
Sorry for the late comment. This PR itself is LGTM. I'd just like to make
some side comments on why this bug is happening.
Janino uses a peculiar encoding of implementing bridge methods
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20779
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20779
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88212/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20779
**[Test build #88212 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88212/testReport)**
for PR 20779 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20779
**[Test build #88212 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88212/testReport)**
for PR 20779 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20779
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1493/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20779
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20779
ping @hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20779
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88154/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20779
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20779
**[Test build #88154 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88154/testReport)**
for PR 20779 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20779
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1451/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20779
**[Test build #88154 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88154/testReport)**
for PR 20779 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20779
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20779
Let me reduce the number of loops. Another option is to revert this change
to use non-loop version that worked without an exception.
---
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/20779
I don't think so. There is an option to change the heap size for test
execution, but I am not sure we are allowed/it is a good idea to do that. Let's
hear others' opinion...
---
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20779
Ah, I increased the heap size (4GB) in my environment with IntelliJ.
Should we create a class like https://github.com/apache/spark/pull/20636?
---
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/20779
@kiszk the UT error is valid. How did you tested it? Any idea about the
reason of the OOM?
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20779
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20779
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88147/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20779
**[Test build #88147 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88147/testReport)**
for PR 20779 at commit
Github user dvogelbacher commented on the issue:
https://github.com/apache/spark/pull/20779
LGTM as well, thanks for making the PR @kiszk
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/20779
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20779
**[Test build #88147 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88147/testReport)**
for PR 20779 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20779
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20779
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1444/
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20779
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20779
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20779
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88145/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20779
**[Test build #88145 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88145/testReport)**
for PR 20779 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20779
**[Test build #88145 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88145/testReport)**
for PR 20779 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20779
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1442/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20779
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20779
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20779
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88131/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20779
**[Test build #88131 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88131/testReport)**
for PR 20779 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20779
**[Test build #88131 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88131/testReport)**
for PR 20779 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20779
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1431/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20779
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20779
@dvogelbacher Great, I have been also investigating the similar approach
(i.e. concatenating `agg()`). Let me try your case.
---
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20779
Yeah, I agree that if we can find an appropriate test case, that'd be
better. Let's see if @dvogelbacher's test case works. Thanks!
---
Github user dvogelbacher commented on the issue:
https://github.com/apache/spark/pull/20779
Note though, that executing this also sometimes slays the compiler (and
sometimes it doesn't and leads to the above error):
```
That entry seems to have slain the compiler. Shall I
Github user dvogelbacher commented on the issue:
https://github.com/apache/spark/pull/20779
I was able to reproduce just now without changing the value of the constant
(i.e., with unmodified code from master):
> â spark git:(master) ./bin/spark-shell
18/03/09 11:11:02
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/20779
I don't want to block it, I just thought that if we can add a new test case
for such situations it would be better, in order also to prevent regression in
the future; since the next release is not
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20779
Looks like this issue is reasonable and we will hit it under some
situations. Currently it is hard to find a reproducible test case, but this
change can prevent it. Do we have any reason to block
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/20779
I am not sure. If you set it to -1,every new function generates a new inner
class, i.e. 1+ entries in the constant pool. So a not very big query can crash.
Moreover, since that is a constant, I
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20779
Under the current situation, I think that we have to create very very huge
query since we made codegen stable.
---
-
To
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/20779
I'd rather avoid to change it, because modifying it we can always trigger
exceptions like the constant pool size limit. Can't we repro this without
changing that value?
---
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20779
Good point. If we could set a specific value to
`GENERATED_CLASS_SIZE_THRESHOLD`, we can add a test case.
How do we make `GENERATED_CLASS_SIZE_THRESHOLD` non-final for testing? For
example, by
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20779
Use the example in the PR description?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/20779
@kiszk can we add a test case for this?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20779
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20779
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88110/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20779
**[Test build #88110 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88110/testReport)**
for PR 20779 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20779
Looks good.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20779
cc: @hvanhovell @mgaido91
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20779
**[Test build #88110 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88110/testReport)**
for PR 20779 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20779
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20779
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1415/
59 matches
Mail list logo
