Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20795
**[Test build #89142 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89142/testReport)**
for PR 20795 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20795
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20795
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88580/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20795
**[Test build #88580 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88580/testReport)**
for PR 20795 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20795
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20795
**[Test build #88580 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88580/testReport)**
for PR 20795 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20795
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20795
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88576/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20795
**[Test build #88576 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88576/testReport)**
for PR 20795 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20795
**[Test build #88576 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88576/testReport)**
for PR 20795 at commit
Github user kevinyu98 commented on the issue:
https://github.com/apache/spark/pull/20795
@viirya yes, my latest submitted code only caching the external functions,
skip the built-in functions.
@WeichenXu123 I will change this comment only
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20795
Can we just skip caching for built-in functions?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user kevinyu98 commented on the issue:
https://github.com/apache/spark/pull/20795
the reason I was thinking to split is for the below scenario:
In order to avoid cache twice for the external function name in the cache
as the scenario described by Dilip, we decide to use
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/20795
Yea, I understand the reason to split built-in and external because you
only want to cache external function name. But cache all used function names in
a query do not cost too much so that
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20795
I'm also a bit confusing why we need to split built-in and external
functions.
---
-
To unsubscribe, e-mail:
Github user kevinyu98 commented on the issue:
https://github.com/apache/spark/pull/20795
@WeichenXu123 I didn't split until this disussion [discussion]
(https://github.com/apache/spark/pull/20795#discussion_r175156300). The
original jira report is about lookup HiveSessionCatalog, so
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/20795
And I don't think it need to split into builtin and external function exist
check in this case. Just following code works fine:
```
object LookupFunctions extends Rule[LogicalPlan] {
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20795
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20795
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88447/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20795
**[Test build #88447 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88447/testReport)**
for PR 20795 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20795
**[Test build #88447 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88447/testReport)**
for PR 20795 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20795
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20795
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88386/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20795
**[Test build #88386 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88386/testReport)**
for PR 20795 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20795
**[Test build #88386 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88386/testReport)**
for PR 20795 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20795
Please ping me if this is ready to review.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20795
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20795
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88292/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20795
**[Test build #88292 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88292/testReport)**
for PR 20795 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20795
**[Test build #88292 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88292/testReport)**
for PR 20795 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20795
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20795
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88189/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20795
**[Test build #88189 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88189/testReport)**
for PR 20795 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20795
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88188/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20795
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20795
**[Test build #88188 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88188/testReport)**
for PR 20795 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20795
**[Test build #88189 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88189/testReport)**
for PR 20795 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20795
**[Test build #88188 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88188/testReport)**
for PR 20795 at commit
Github user kevinyu98 commented on the issue:
https://github.com/apache/spark/pull/20795
@viirya Thanks a lot. I will create a new test file LookupFunctionsSuite
under sql/catalyst/analysis.
---
-
To unsubscribe,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20795
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88161/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20795
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20795
**[Test build #88161 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88161/testReport)**
for PR 20795 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20795
I've added a test like this:
```scala
class LookupFunctionsSuite extends PlanTest {
test("SPARK-23486: LookupFunctions should not check the same function
name more than once")
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20795
**[Test build #88161 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88161/testReport)**
for PR 20795 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20795
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20795
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20795
test this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20795
ok to test
(seems uppercase not working somehow with Jenkins .. )
---
-
To unsubscribe, e-mail:
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20795
Ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20795
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20795
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
51 matches
Mail list logo
