Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20850
Merging to master. Thanks for your hard work and patience.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20850
@hvanhovell Here are results of `UnsafeProjectionBenchmark`. I have not
seen the regression.
With master `529f847105fa8d98a5dc4d20955e4870df6bc1c5`
```
OpenJDK 64-Bit Server VM
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20850
@kiszk can you rerun the `UnsafeProjectionBenchmark` to make sure we didn't
regress anywhere?
Otherwise LGTM.
---
-
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20850
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88801/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20850
**[Test build #88801 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88801/testReport)**
for PR 20850 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1893/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20850
**[Test build #88801 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88801/testReport)**
for PR 20850 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88789/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20850
**[Test build #88789 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88789/testReport)**
for PR 20850 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20850
**[Test build #88789 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88789/testReport)**
for PR 20850 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1886/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20850
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20850
**[Test build #88787 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88787/testReport)**
for PR 20850 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88787/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1884/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20850
**[Test build #88787 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88787/testReport)**
for PR 20850 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88760/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20850
**[Test build #88760 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88760/testReport)**
for PR 20850 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1866/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20850
**[Test build #88760 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88760/testReport)**
for PR 20850 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20850
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88728/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20850
**[Test build #88728 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88728/testReport)**
for PR 20850 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1848/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20850
**[Test build #88728 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88728/testReport)**
for PR 20850 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20850
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88718/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20850
**[Test build #88718 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88718/testReport)**
for PR 20850 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1840/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20850
**[Test build #88718 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88718/testReport)**
for PR 20850 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88672/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20850
**[Test build #88672 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88672/testReport)**
for PR 20850 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1810/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20850
**[Test build #88672 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88672/testReport)**
for PR 20850 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20850
@hvanhovell sorry for ping again
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88616/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20850
**[Test build #88616 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88616/testReport)**
for PR 20850 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20850
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1773/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20850
**[Test build #88616 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88616/testReport)**
for PR 20850 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88593/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20850
**[Test build #88593 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88593/testReport)**
for PR 20850 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1762/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20850
**[Test build #88593 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88593/testReport)**
for PR 20850 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20850
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20850
ping @hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88411/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20850
**[Test build #88411 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88411/testReport)**
for PR 20850 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1636/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20850
**[Test build #88411 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88411/testReport)**
for PR 20850 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20850
@hvanhovell btw, (this is not related to this pr thought...) the most part
of code in `UTF8StringBuffer` and `BufferHolder` are overlapped. So, we could
clean up there, too?
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88380/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20850
**[Test build #88380 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88380/testReport)**
for PR 20850 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88378/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20850
**[Test build #88378 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88378/testReport)**
for PR 20850 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20850
**[Test build #88380 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88380/testReport)**
for PR 20850 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1614/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1613/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20850
**[Test build #88378 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88378/testReport)**
for PR 20850 at commit
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20850
@kiszk this is a good start! This is very performance critical code, can
you please extend/update/run the existing `UnsafeProjectionBenchmark`?
---
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20850
This test is consistently failed. While I did not change file reader, I am
investigating the reason in my environment.
---
-
To
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88373/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20850
**[Test build #88373 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88373/testReport)**
for PR 20850 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20850
**[Test build #88373 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88373/testReport)**
for PR 20850 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1608/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20850
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88347/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20850
**[Test build #88347 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88347/testReport)**
for PR 20850 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20850
**[Test build #88347 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88347/testReport)**
for PR 20850 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1585/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20850
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
1 - 100 of 114 matches
Mail list logo
