[GitHub] spark issue #20858: [SPARK-23736][SQL] Implementation of the concat_arrays f...

2018-03-26 Thread mn-mikke
Github user mn-mikke commented on the issue: https://github.com/apache/spark/pull/20858 retest please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20858: [SPARK-23736][SQL] Implementation of the concat_arrays f...

2018-03-26 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20858 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20858: [SPARK-23736][SQL] Implementation of the concat_arrays f...

2018-03-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20858 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20858: [SPARK-23736][SQL] Implementation of the concat_arrays f...

2018-03-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20858 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88596/ Test FAILed. ---

[GitHub] spark issue #20858: [SPARK-23736][SQL] Implementation of the concat_arrays f...

2018-03-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20858 **[Test build #88596 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88596/testReport)** for PR 20858 at commit

[GitHub] spark issue #20858: [SPARK-23736][SQL] Implementation of the concat_arrays f...

2018-03-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20858 **[Test build #88596 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88596/testReport)** for PR 20858 at commit

[GitHub] spark issue #20858: [SPARK-23736][SQL] Implementation of the concat_arrays f...

2018-03-26 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20858 @mn-mikke Could you update the PR title? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20858: [SPARK-23736][SQL] Implementation of the concat_arrays f...

2018-03-26 Thread mn-mikke
Github user mn-mikke commented on the issue: https://github.com/apache/spark/pull/20858 Merged concat and concat_arrays functions into one via an unresolved expression and subsequent resolution. Do you have any objections to this approach? ---

[GitHub] spark issue #20858: [SPARK-23736][SQL] Implementation of the concat_arrays f...

2018-03-25 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20858 Also, `postgresql` has the function `array_cat` for concatenating arrays, so it might be better to make the behaviour the same with the `postgresql` one:

[GitHub] spark issue #20858: [SPARK-23736][SQL] Implementation of the concat_arrays f...

2018-03-25 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20858 We should handle different (and compatible) typed arrays in this funs? ``` scala> sql("select concat_arrays(array(1L, 2L), array(3, 4))").show org.apache.spark.sql.AnalysisException:

[GitHub] spark issue #20858: [SPARK-23736][SQL] Implementation of the concat_arrays f...

2018-03-25 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20858 The current code can't handle inner arrays; ``` scala> sql("select concat_arrays(array(1, 2, array(3, 4)), array(5, 6, 7, 8))").show org.apache.spark.sql.AnalysisException: cannot resolve

[GitHub] spark issue #20858: [SPARK-23736][SQL] Implementation of the concat_arrays f...

2018-03-23 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20858 ok, I'll check later! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20858: [SPARK-23736][SQL] Implementation of the concat_arrays f...

2018-03-22 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20858 @maropu Maybe you can help @mn-mikke review this PR ? Will open an umbrella JIRA for the built-in functions we plan to do in Apache 2.4. In the list, we have multiple for operating nested

[GitHub] spark issue #20858: [SPARK-23736][SQL] Implementation of the concat_arrays f...

2018-03-20 Thread mn-mikke
Github user mn-mikke commented on the issue: https://github.com/apache/spark/pull/20858 @maropu What other libraries do you mean? I'm not aware of any library providing this functionality on top Spark SQL. When using Spark SQL as an ETL tool for structured and nested data,

[GitHub] spark issue #20858: [SPARK-23736][SQL] Implementation of the concat_arrays f...

2018-03-19 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20858 Thinks for this work! One question; why do you think we need to support this api in Spark native? Other libraries support this as first-class? ---

[GitHub] spark issue #20858: [SPARK-23736][SQL] Implementation of the concat_arrays f...

2018-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20858 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20858: [SPARK-23736][SQL] Implementation of the concat_arrays f...

2018-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20858 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional