[GitHub] spark issue #21071: [SPARK-21962][CORE] Distributed Tracing in Spark

2018-04-22 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/21071 @devaraj-kavali can you close this PR first? Looks like there isn't any reason to really use htrace anymore ... --- - To

[GitHub] spark issue #21071: [SPARK-21962][CORE] Distributed Tracing in Spark

2018-04-21 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/21071 yap... HTrace is

[GitHub] spark issue #21071: [SPARK-21962][CORE] Distributed Tracing in Spark

2018-04-17 Thread devaraj-kavali
Github user devaraj-kavali commented on the issue: https://github.com/apache/spark/pull/21071 @gatorsmile we need to have this for K8S as well, will include it in SPIP. --- - To unsubscribe, e-mail:

[GitHub] spark issue #21071: [SPARK-21962][CORE] Distributed Tracing in Spark

2018-04-17 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/21071 @devaraj-kavali How about K8S? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #21071: [SPARK-21962][CORE] Distributed Tracing in Spark

2018-04-17 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/21071 cc @jiangxb1987 @JoshRosen --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #21071: [SPARK-21962][CORE] Distributed Tracing in Spark

2018-04-17 Thread devaraj-kavali
Github user devaraj-kavali commented on the issue: https://github.com/apache/spark/pull/21071 Thanks @rxin and @markhamstra for your comments, I will come up with SPIP design draft and start the discussion. --- -

[GitHub] spark issue #21071: [SPARK-21962][CORE] Distributed Tracing in Spark

2018-04-16 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/21071 @rxin +1 for each of your sentences. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21071: [SPARK-21962][CORE] Distributed Tracing in Spark

2018-04-16 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/21071 This probably deserves its own SPIP. Also unclear whether we should just support htrace, or have an extension api so users can plug in whatever they want. ---

[GitHub] spark issue #21071: [SPARK-21962][CORE] Distributed Tracing in Spark

2018-04-16 Thread rdblue
Github user rdblue commented on the issue: https://github.com/apache/spark/pull/21071 Some metrics to convince ourselves that using the null scope has no performance impact would be great. --- - To unsubscribe,

[GitHub] spark issue #21071: [SPARK-21962][CORE] Distributed Tracing in Spark

2018-04-16 Thread devaraj-kavali
Github user devaraj-kavali commented on the issue: https://github.com/apache/spark/pull/21071 Thanks @steveloughran and @rdblue for looking into this. bq. this turns HTrace on always; do you think it should be optional It operates on NullScope which doesn't do anything

[GitHub] spark issue #21071: [SPARK-21962][CORE] Distributed Tracing in Spark

2018-04-16 Thread rdblue
Github user rdblue commented on the issue: https://github.com/apache/spark/pull/21071 @devaraj-kavali, do you have any measurements to quantify how this impacts overall performance? We would want to know before releasing this for use because using HTrace means having it on all the

[GitHub] spark issue #21071: [SPARK-21962][CORE] Distributed Tracing in Spark

2018-04-16 Thread steveloughran
Github user steveloughran commented on the issue: https://github.com/apache/spark/pull/21071 I like this, but you'll need people with authority to trigger the builds and reviews. There's some discussion kicked off last week on the ASF incubator about the fact that htrace has

[GitHub] spark issue #21071: [SPARK-21962][CORE] Distributed Tracing in Spark

2018-04-16 Thread steveloughran
Github user steveloughran commented on the issue: https://github.com/apache/spark/pull/21071 + @rdblue --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21071: [SPARK-21962][CORE] Distributed Tracing in Spark

2018-04-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21071 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21071: [SPARK-21962][CORE] Distributed Tracing in Spark

2018-04-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21071 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional