Github user liyinan926 commented on the issue:
https://github.com/apache/spark/pull/21095
@madanadit can you close this as #21260 has been merged?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21095
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user madanadit commented on the issue:
https://github.com/apache/spark/pull/21095
Thanks @liyinan926 for the review and @andrusha for addressing the comments
and moving the work along. I can close this PR once #21260 merges.
---
Github user andrusha commented on the issue:
https://github.com/apache/spark/pull/21095
@liyinan926 that's the idea. We should have a single step to mount all
kinds of volumes including hostPath and emptyDir. The only problem is the
configuration awkwardness.
---
Github user liyinan926 commented on the issue:
https://github.com/apache/spark/pull/21095
@andrusha Is the purpose of https://github.com/apache/spark/pull/21260 to
replace both this PR and https://github.com/apache/spark/pull/21238?
---
Github user andrusha commented on the issue:
https://github.com/apache/spark/pull/21095
@madanadit @liyinan926 @foxish I addressed comments here and added PVC
support https://github.com/apache/spark/pull/21260. However I'm unsure if this
is the right way to go, please check the PR.
Github user foxish commented on the issue:
https://github.com/apache/spark/pull/21095
The testing is not a blocker for the review. When I said "tests for
non-hostpath type volumes", I meant to say that we want to cover more than just
hostpath mounts with the initial PR - because we
Github user madanadit commented on the issue:
https://github.com/apache/spark/pull/21095
Hi @foxish, I don't see why the 2 testing concerns should block reviewing
this PR.
1. This PR does not attempt to address non-hostpath volumes (both
implementation and unit tests are hence
Github user liyinan926 commented on the issue:
https://github.com/apache/spark/pull/21095
@madanadit sorry I didn't get a chance to look into this. I will take a
detailed look once @foxish's comments on testing are addressed.
---
Github user foxish commented on the issue:
https://github.com/apache/spark/pull/21095
@madanadit, sorry about the long turnaround time here. I made a cursory
pass over it - and it looks good. Before getting deeper into the code, I think
we need more exhaustive unit testing for
Github user madanadit commented on the issue:
https://github.com/apache/spark/pull/21095
Hey @liyinan926, do you think you'll have time to take a look this week?
---
-
To unsubscribe, e-mail:
Github user liyinan926 commented on the issue:
https://github.com/apache/spark/pull/21095
Thanks @madanadit! I will take a look over the weekend or early net week.
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21095
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/2450/
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21095
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21095
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/2450/
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21095
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2505/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21095
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89601/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21095
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21095
**[Test build #89601 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89601/testReport)**
for PR 21095 at commit
Github user madanadit commented on the issue:
https://github.com/apache/spark/pull/21095
@liyinan926 Thanks for the comment. I refactored it to address your
concern. The code is simple enough to be easily refactored if the need be by
whoever implements the next volume type.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21095
**[Test build #89601 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89601/testReport)**
for PR 21095 at commit
Github user liyinan926 commented on the issue:
https://github.com/apache/spark/pull/21095
My general comment is the code is centered around parsing and setting up
`hostPath` volumes even though the proposal is generic. I would suggest making
the code generic as well. Particularly I
Github user madanadit commented on the issue:
https://github.com/apache/spark/pull/21095
Thanks @foxish for your feedback. As a first time contributor to Spark, I
would like to limit the scope of the changes in this PR. Let me know when
you're ready to review again.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21095
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/2398/
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21095
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89529/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21095
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21095
**[Test build #89529 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89529/testReport)**
for PR 21095 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21095
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21095
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2451/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21095
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/2398/
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21095
**[Test build #89529 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89529/testReport)**
for PR 21095 at commit
Github user foxish commented on the issue:
https://github.com/apache/spark/pull/21095
@madanadit, thanks for following up with the PR and for your [design
doc](https://docs.google.com/document/d/15-mk7UnOYNTXoF6EKaVlelWYc9DTrTXrYoodwDuAwY4/edit#heading=h.8jlem461uvwv).
I had a few
Github user foxish commented on the issue:
https://github.com/apache/spark/pull/21095
jenkins, ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21095
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user madanadit commented on the issue:
https://github.com/apache/spark/pull/21095
@liyinan926 @foxish Please take a look
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21095
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
36 matches
Mail list logo
