Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21203
@jkbradley A follow-up has been submitted and merged. Please see #21211.
Thanks.
---
-
To unsubscribe, e-mail:
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/21203
It's OK but would you mind fixing it @viirya before we use it in
https://github.com/apache/spark/pull/21153 ? Thanks!
---
-
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21203
Sorry @jkbradley, I rushed it. It looked making sense when I merged this
but I didn't closely check the Scala side. Will be careful next time.
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21203
I missed that comment too. Yea, I think it makes more sense to throw an
exception - I usually use `ValueError` in this case though. Please go ahead for
a followup.
---
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21203
ah, sorry, @jkbradley asked me to do a little change like throwing
exception when can't paring input. My flight just lands now. Let me submit a
small follow-up.
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21203
Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21203
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21203
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89982/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21203
**[Test build #89982 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89982/testReport)**
for PR 21203 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21203
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21203
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2754/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21203
**[Test build #89982 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89982/testReport)**
for PR 21203 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21203
Retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21203
> perhaps better to match python's version_info ?
This for now is more close to `VersionUtils.majorMinorVersion`. To match
python's version_info, means we need to have 5 components?
---
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21203
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21203
This is moved from #21153 based on @jkbradley's suggestion.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21203
cc @jkbradley @HyukjinKwon @dbtsai
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
17 matches
Mail list logo
