Github user liyinan926 commented on the issue:
https://github.com/apache/spark/pull/21238
Makes sense to me.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user foxish commented on the issue:
https://github.com/apache/spark/pull/21238
SG. @liyinan926, let's revisit this if we hear from 2.3 users.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/21238
What would make this difficult to backport is the fact that this patch was
built on top of the big refactor PR that only went in after 2.3. So we'd need
to rewrite this with the old architecture
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/21238
I think we can afford to hold off here.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user foxish commented on the issue:
https://github.com/apache/spark/pull/21238
@mccheah, wdyt? I just haven't heard from any users here of 2.3 - if you
think it's useful for 2.3.1 and low risk, then please feel free to propose a
cherrypick.
---
Github user foxish commented on the issue:
https://github.com/apache/spark/pull/21238
Maintenance releases most often have fixes for stability. We could maybe
backport this since it's not a new feature but an omission from before. If it
is going to be some effort, thanks to all the
Github user liyinan926 commented on the issue:
https://github.com/apache/spark/pull/21238
@foxish @mccheah should we also merge this to branch-2.3? I think we should
target this for 2.3.1.
---
-
To unsubscribe,
Github user foxish commented on the issue:
https://github.com/apache/spark/pull/21238
LGTM. Merging to master.
Thanks @mccheah
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/21238
Requesting sign off and merge from @foxish
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21238
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90432/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21238
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21238
**[Test build #90432 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90432/testReport)**
for PR 21238 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21238
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21238
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90431/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21238
**[Test build #90431 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90431/testReport)**
for PR 21238 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21238
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/3002/
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21238
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3088/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21238
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/3002/
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21238
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21238
**[Test build #90432 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90432/testReport)**
for PR 21238 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21238
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3087/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21238
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21238
**[Test build #90431 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90431/testReport)**
for PR 21238 at commit
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/21238
@rxin @liyinan926 @foxish addressed comments.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user erikerlandson commented on the issue:
https://github.com/apache/spark/pull/21238
I agree with @mcheah that the potential code reuse is small. Keeping this
as a separate pod construction step, decoupled from the user-exposed step, is
cleaner.
---
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/21238
Also #21260 currently only supports hostPath and PVCs but you definitely
want emptyDir for isolation (though that looks like a trivial enough change).
---
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/21238
@andrusha I don't think it's entirely analogous - for the simple reason
that the hostPath volumes PR doesn't take into account `SPARK_LOCAL_DIRS`. That
environment variable is used to determine the
Github user andrusha commented on the issue:
https://github.com/apache/spark/pull/21238
Seems like it addresses similar problem to
https://github.com/apache/spark/pull/21095. It might be worth investigating how
to unify both.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21238
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21238
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90225/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21238
**[Test build #90225 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90225/testReport)**
for PR 21238 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21238
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/2854/
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21238
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/2854/
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21238
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2931/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21238
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21238
**[Test build #90225 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90225/testReport)**
for PR 21238 at commit
36 matches
Mail list logo
