Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21252
can you change the PR title? otherwise LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21252
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21252
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90692/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21252
**[Test build #90692 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90692/testReport)**
for PR 21252 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21252
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3271/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21252
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21252
**[Test build #90692 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90692/testReport)**
for PR 21252 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21252
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21252
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90670/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21252
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21252
**[Test build #90670 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90670/testReport)**
for PR 21252 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21252
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3250/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21252
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21252
**[Test build #90670 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90670/testReport)**
for PR 21252 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21252
**[Test build #90630 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90630/testReport)**
for PR 21252 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21252
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90630/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21252
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21252
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3224/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21252
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21252
**[Test build #90630 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90630/testReport)**
for PR 21252 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21252
Thanks! LGTM.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/21252
PR description updated.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21252
> How was this patch tested?
> Not added yet.
Test is added. Can you update PR description?
---
-
To unsubscribe,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21252
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21252
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90408/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21252
**[Test build #90408 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90408/testReport)**
for PR 21252 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21252
**[Test build #90408 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90408/testReport)**
for PR 21252 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21252
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21252
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3071/
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21252
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21252
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21252
**[Test build #90406 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90406/testReport)**
for PR 21252 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21252
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90406/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21252
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21252
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3070/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21252
**[Test build #90406 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90406/testReport)**
for PR 21252 at commit
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/21252
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21252
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90368/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21252
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21252
**[Test build #90368 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90368/testReport)**
for PR 21252 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21252
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3039/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21252
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21252
**[Test build #90368 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90368/testReport)**
for PR 21252 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21252
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90315/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21252
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21252
**[Test build #90315 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90315/testReport)**
for PR 21252 at commit
Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/21252
I will add a suite tomorrow.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21252
We can have a test to check the physical plan under different threshold.
---
-
To unsubscribe, e-mail:
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/21252
The changes looks good to me, but it should also be great to have a test
suite to cover this change. Seems we don't have a test suite for the rule
`SpecialLimits` ?
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21252
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21252
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2998/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21252
**[Test build #90315 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90315/testReport)**
for PR 21252 at commit
Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/21252
@cloud-fan @viirya
Thanks for comments. I refined accordingly. Please check~
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21252
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90296/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21252
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21252
**[Test build #90296 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90296/testReport)**
for PR 21252 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21252
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2979/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21252
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/21252
> Instead of touching inside of TakeOrderedAndProjectExec, how about we
don't replace Sort + Limit with TakeOrderedAndProjectExec when reaching the
threshold?
Yes, the code will be much
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21252
**[Test build #90296 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90296/testReport)**
for PR 21252 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21252
Instead of touching inside of `TakeOrderedAndProjectExec`, how about we
don't replace `Sort` + `Limit` with `TakeOrderedAndProjectExec` when reaching
the threshold? A.k.a:
```scala
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21252
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90282/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21252
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21252
**[Test build #90282 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90282/testReport)**
for PR 21252 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21252
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2967/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21252
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21252
**[Test build #90282 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90282/testReport)**
for PR 21252 at commit
Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/21252
cc @cloud-fan @viirya
I'm not sure if you are interested in this config.
Could you please give some advice?
Thanks a lot !
---
68 matches
Mail list logo
