Github user cxzl25 commented on the issue:
https://github.com/apache/spark/pull/21311
@cloud-fan Thank you very much for your help.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21311
thanks, merging to master/2.3/2.2/2.1/2.0! There is no conflict so I
backported all the way to 2.0. I'll watch the jenkins build in the few days.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21311
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91066/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21311
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21311
**[Test build #91066 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91066/testReport)**
for PR 21311 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21311
**[Test build #91066 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91066/testReport)**
for PR 21311 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21311
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21311
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91052/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21311
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21311
**[Test build #91052 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91052/testReport)**
for PR 21311 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21311
**[Test build #91052 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91052/testReport)**
for PR 21311 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/21311
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21311
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91041/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21311
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21311
**[Test build #91041 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91041/testReport)**
for PR 21311 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21311
**[Test build #91041 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91041/testReport)**
for PR 21311 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21311
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21311
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91018/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21311
**[Test build #91018 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91018/testReport)**
for PR 21311 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21311
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21311
**[Test build #91018 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91018/testReport)**
for PR 21311 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21311
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21311
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91009/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21311
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21311
**[Test build #91009 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91009/testReport)**
for PR 21311 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21311
**[Test build #91009 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91009/testReport)**
for PR 21311 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21311
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21311
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90981/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21311
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21311
**[Test build #90981 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90981/testReport)**
for PR 21311 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21311
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21311
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90970/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21311
**[Test build #90970 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90970/testReport)**
for PR 21311 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21311
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21311
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90967/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21311
**[Test build #90967 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90967/testReport)**
for PR 21311 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21311
**[Test build #90981 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90981/testReport)**
for PR 21311 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21311
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21311
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90966/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21311
**[Test build #90966 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90966/testReport)**
for PR 21311 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21311
LGTM, good catch!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21311
**[Test build #90970 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90970/testReport)**
for PR 21311 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21311
**[Test build #90967 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90967/testReport)**
for PR 21311 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21311
**[Test build #90966 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90966/testReport)**
for PR 21311 at commit
Github user cxzl25 commented on the issue:
https://github.com/apache/spark/pull/21311
@cloud-fan
LongToUnsafeRowMap#append(key: Long, row: UnsafeRow)
when row.getSizeInBytes > newPageSize( oldPage.length * 8L * 2),still use
newPageSize value.
When the new page size is
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21311
> Calculate the new size simply by multiplying by 2
At this time, the size of the application may not be enough to store data
Some data is lost and the data read out is dirty
Can
Github user cxzl25 commented on the issue:
https://github.com/apache/spark/pull/21311
@JoshRosen @cloud-fan @gatorsmile
When introducing
[SPARK-10399](https://issues.apache.org/jira/browse/SPARK-10399),UnsafeRow#getUTF8String
check the size at this time.
Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/21311
@cxzl25, to clarify:
> Some data is lost and the data read out is dirty
To clarify, is this a potential cause of a wrong-answer correctness bug? If
so, we should be sure to
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21311
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90574/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21311
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21311
**[Test build #90574 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90574/testReport)**
for PR 21311 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21311
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90575/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21311
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21311
**[Test build #90575 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90575/testReport)**
for PR 21311 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21311
**[Test build #90575 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90575/testReport)**
for PR 21311 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21311
**[Test build #90574 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90574/testReport)**
for PR 21311 at commit
Github user cxzl25 commented on the issue:
https://github.com/apache/spark/pull/21311
Thanks for your review. @maropu @kiszk @cloud-fan
I submitted a modification including the following:
1. spliting append func into two parts:grow/appendG
2. doubling the size when
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21311
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21311
cc @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21311
@gatorsmile @hvanhovell Could you trigger tests?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21311
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21311
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
62 matches
Mail list logo
