[GitHub] spark issue #21318: [minor] Update docs for functions.scala to make it clear...

Github user rxin commented on the issue: https://github.com/apache/spark/pull/21318 LGTM. On Fri, Jul 27, 2018 at 10:58 PM Hyukjin Kwon wrote: > @rxin re: #21318 (comment) >

[GitHub] spark issue #21318: [minor] Update docs for functions.scala to make it clear...

Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21318 @rxin re: https://github.com/apache/spark/pull/21318#discussion_r20582 I meant to say for instance, like "Please refer the SQL function documentation in the corresponding version". We don't

[GitHub] spark issue #21318: [minor] Update docs for functions.scala to make it clear...

Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/21318 Thanks! Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21318: [minor] Update docs for functions.scala to make it clear...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21318 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21318: [minor] Update docs for functions.scala to make it clear...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21318 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93695/ Test PASSed. ---

[GitHub] spark issue #21318: [minor] Update docs for functions.scala to make it clear...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21318 **[Test build #93695 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93695/testReport)** for PR 21318 at commit

[GitHub] spark issue #21318: [minor] Update docs for functions.scala to make it clear...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21318 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21318: [minor] Update docs for functions.scala to make it clear...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21318 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #21318: [minor] Update docs for functions.scala to make it clear...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21318 **[Test build #93695 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93695/testReport)** for PR 21318 at commit

[GitHub] spark issue #21318: [minor] Update docs for functions.scala to make it clear...

Github user rxin commented on the issue: https://github.com/apache/spark/pull/21318 Yup will do. On Fri, Jul 27, 2018 at 10:23 AM Sean Owen wrote: > Just browsing old PRs .. want to finish this one up @rxin > ? looks simple and

[GitHub] spark issue #21318: [minor] Update docs for functions.scala to make it clear...

Github user srowen commented on the issue: https://github.com/apache/spark/pull/21318 Just browsing old PRs .. want to finish this one up @rxin? looks simple and useful. --- - To unsubscribe, e-mail:

[GitHub] spark issue #21318: [minor] Update docs for functions.scala to make it clear...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21318 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21318: [minor] Update docs for functions.scala to make it clear...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21318 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90625/ Test FAILed. ---

[GitHub] spark issue #21318: [minor] Update docs for functions.scala to make it clear...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21318 **[Test build #90625 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90625/testReport)** for PR 21318 at commit

[GitHub] spark issue #21318: [minor] Update docs for functions.scala to make it clear...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21318 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3221/

[GitHub] spark issue #21318: [minor] Update docs for functions.scala to make it clear...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21318 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21318: [minor] Update docs for functions.scala to make it clear...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21318 **[Test build #90625 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90625/testReport)** for PR 21318 at commit

[GitHub] spark issue #21318: [minor] Update docs for functions.scala to make it clear...

Github user rxin commented on the issue: https://github.com/apache/spark/pull/21318 It's still going to fail because I haven't updated it yet. Will do tomorrow. --- - To unsubscribe, e-mail:

[GitHub] spark issue #21318: [minor] Update docs for functions.scala to make it clear...

Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/21318 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21318: [minor] Update docs for functions.scala to make it clear...

Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21318 @rxin, should we maybe we mention that SQL functions are usually added to match other DBMSs (unlike functions.scala)? --- -

[GitHub] spark issue #21318: [minor] Update docs for functions.scala to make it clear...

Github user rxin commented on the issue: https://github.com/apache/spark/pull/21318 Hm the failure doesn't look like it's caused by this PR. Do you guys know what's going on? --- - To unsubscribe, e-mail:

[GitHub] spark issue #21318: [minor] Update docs for functions.scala to make it clear...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21318 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21318: [minor] Update docs for functions.scala to make it clear...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21318 **[Test build #90567 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90567/testReport)** for PR 21318 at commit

[GitHub] spark issue #21318: [minor] Update docs for functions.scala to make it clear...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21318 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90567/ Test FAILed. ---

[GitHub] spark issue #21318: [minor] Update docs for functions.scala to make it clear...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21318 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3187/

[GitHub] spark issue #21318: [minor] Update docs for functions.scala to make it clear...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21318 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21318: [minor] Update docs for functions.scala to make it clear...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21318 **[Test build #90567 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90567/testReport)** for PR 21318 at commit

[GitHub] spark issue #21318: [minor] Update docs for functions.scala to make it clear...

Github user rxin commented on the issue: https://github.com/apache/spark/pull/21318 cc @gatorsmile @HyukjinKwon --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: