Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21329
The history is exactly like what @JoshRosen said: the conf setting logic is
there at the write side since day 1, and then #101 applied it to the read side.
My major concern is the driver side
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/21329
@JoshRosen Thanks for the explaination. I can understand your concerns.
My main point is the job/task ID here
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21329
Let me revert it now. @gengliangwang Please address the code comments and
resubmit the PR. Thanks!
---
-
To unsubscribe,
Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/21329
I'd also like to note that commit protocols have historically been a very
high risk area of the code, so I think we should have a much higher bar for
explaining changes to that component.
---
Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/21329
In general, I'm very wary of cleanup changes like this: unless we have a
_need_ to do this (i.e. it causes negative side effects, breaks workloads,
prevents specific concrete improvements, etc.)
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/21329
@rxin When I was implementing writer with Data Source V2, I find the code
in `HadoopMapReduceCommitProtocol` quite misleading.
The code here is just setting configuration
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/21329
Why are we cleaning up stuff like this?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21329
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21329
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21329
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90739/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21329
**[Test build #90739 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90739/testReport)**
for PR 21329 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21329
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21329
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90731/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21329
**[Test build #90731 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90731/testReport)**
for PR 21329 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21329
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3303/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21329
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21329
**[Test build #90739 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90739/testReport)**
for PR 21329 at commit
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/21329
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21329
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21329
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3298/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21329
**[Test build #90731 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90731/testReport)**
for PR 21329 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21329
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21329
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90680/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21329
**[Test build #90680 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90680/testReport)**
for PR 21329 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21329
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21329
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3260/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21329
**[Test build #90680 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90680/testReport)**
for PR 21329 at commit
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/21329
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/21329
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21329
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21329
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90669/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21329
**[Test build #90669 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90669/testReport)**
for PR 21329 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21329
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3249/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21329
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21329
**[Test build #90669 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90669/testReport)**
for PR 21329 at commit
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/21329
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21329
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21329
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90639/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21329
**[Test build #90639 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90639/testReport)**
for PR 21329 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21329
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21329
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3230/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21329
**[Test build #90639 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90639/testReport)**
for PR 21329 at commit
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/21329
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21329
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90631/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21329
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21329
**[Test build #90631 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90631/testReport)**
for PR 21329 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21329
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3225/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21329
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21329
**[Test build #90631 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90631/testReport)**
for PR 21329 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21329
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21329
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90624/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21329
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21329
**[Test build #90624 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90624/testReport)**
for PR 21329 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21329
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21329
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3220/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21329
**[Test build #90624 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90624/testReport)**
for PR 21329 at commit
56 matches
Mail list logo
