[GitHub] spark issue #21344: [SPARK-24114] Add instrumentation to FPGrowth.

2018-05-17 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/21344 Whoops! This was merged linked to the wrong JIRA. It should have been: https://issues.apache.org/jira/browse/SPARK-24310 for the record. ---

[GitHub] spark issue #21344: [SPARK-24114] Add instrumentation to FPGrowth.

2018-05-17 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/21344 LGTM It'll be nice when we move the implementation to spark.ml in the future so that we can log more info, but this is good for now. Thanks @MrBago and @ludatabricks ! Merging

[GitHub] spark issue #21344: [SPARK-24114] Add instrumentation to FPGrowth.

2018-05-17 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/21344 I'll take a look now --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21344: [SPARK-24114] Add instrumentation to FPGrowth.

2018-05-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21344 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90696/ Test PASSed. ---

[GitHub] spark issue #21344: [SPARK-24114] Add instrumentation to FPGrowth.

2018-05-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21344 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21344: [SPARK-24114] Add instrumentation to FPGrowth.

2018-05-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21344 **[Test build #90696 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90696/testReport)** for PR 21344 at commit

[GitHub] spark issue #21344: [SPARK-24114] Add instrumentation to FPGrowth.

2018-05-16 Thread ludatabricks
Github user ludatabricks commented on the issue: https://github.com/apache/spark/pull/21344 LGTM. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21344: [SPARK-24114] Add instrumentation to FPGrowth.

2018-05-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21344 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3274/

[GitHub] spark issue #21344: [SPARK-24114] Add instrumentation to FPGrowth.

2018-05-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21344 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21344: [SPARK-24114] Add instrumentation to FPGrowth.

2018-05-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21344 **[Test build #90696 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90696/testReport)** for PR 21344 at commit

[GitHub] spark issue #21344: [SPARK-24114] Add instrumentation to FPGrowth.

2018-05-16 Thread MrBago
Github user MrBago commented on the issue: https://github.com/apache/spark/pull/21344 @ludatabricks thanks for taking a loo, I added `logParams`. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #21344: [SPARK-24114] Add instrumentation to FPGrowth.

2018-05-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21344 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90687/ Test PASSed. ---

[GitHub] spark issue #21344: [SPARK-24114] Add instrumentation to FPGrowth.

2018-05-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21344 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21344: [SPARK-24114] Add instrumentation to FPGrowth.

2018-05-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21344 **[Test build #90687 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90687/testReport)** for PR 21344 at commit

[GitHub] spark issue #21344: [SPARK-24114] Add instrumentation to FPGrowth.

2018-05-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21344 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21344: [SPARK-24114] Add instrumentation to FPGrowth.

2018-05-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21344 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3266/

[GitHub] spark issue #21344: [SPARK-24114] Add instrumentation to FPGrowth.

2018-05-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21344 **[Test build #90687 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90687/testReport)** for PR 21344 at commit