Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21369
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94678/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21369
**[Test build #94678 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94678/testReport)**
for PR 21369 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21369
**[Test build #94678 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94678/testReport)**
for PR 21369 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user eyalfa commented on the issue:
https://github.com/apache/spark/pull/21369
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94670/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21369
**[Test build #94670 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94670/testReport)**
for PR 21369 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21369
**[Test build #94670 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94670/testReport)**
for PR 21369 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21369
LGTM except some code style issues. Thanks for improving the test!
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94629/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21369
**[Test build #94629 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94629/testReport)**
for PR 21369 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94627/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21369
**[Test build #94627 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94627/testReport)**
for PR 21369 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94626/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21369
**[Test build #94626 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94626/testReport)**
for PR 21369 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21369
**[Test build #94629 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94629/testReport)**
for PR 21369 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user eyalfa commented on the issue:
https://github.com/apache/spark/pull/21369
@hvanhovell ,thanks for picking this up :sunglasses:
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21369
**[Test build #94627 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94627/testReport)**
for PR 21369 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21369
**[Test build #94626 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94626/testReport)**
for PR 21369 at commit
Github user eyalfa commented on the issue:
https://github.com/apache/spark/pull/21369
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94559/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21369
**[Test build #94559 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94559/testReport)**
for PR 21369 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21369
**[Test build #94559 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94559/testReport)**
for PR 21369 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/21369
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21369
cc @gatorsmile , can we copy some test code from scala?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21369
**[Test build #91146 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91146/testReport)**
for PR 21369 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91146/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3579/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21369
**[Test build #91146 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91146/testReport)**
for PR 21369 at commit
Github user eyalfa commented on the issue:
https://github.com/apache/spark/pull/21369
@cloud-fan , i guess we can copy the test util from scala as long as it
doesnt violet licensing or credits, please advice on the proper way of
doingbthat and where do u want to place the code? Does
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91109/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21369
**[Test build #91109 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91109/testReport)**
for PR 21369 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91101/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21369
**[Test build #91101 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91101/testReport)**
for PR 21369 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3554/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21369
the patch LGTM, but I'm not sure the test is useful. it's too coupled with
the implementation and if we have reference leak again, I don't think the test
can help to detect it.
Can we
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21369
**[Test build #91109 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91109/testReport)**
for PR 21369 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3549/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21369
**[Test build #91101 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91101/testReport)**
for PR 21369 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91065/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21369
**[Test build #91065 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91065/testReport)**
for PR 21369 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3522/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21369
**[Test build #91065 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91065/testReport)**
for PR 21369 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21369
cc @JoshRosen
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user advancedxy commented on the issue:
https://github.com/apache/spark/pull/21369
> @advancedxy , using jvisualvm+heap dump I could see that the second
introduced test case ("drop all references to the underlying map once the
iterator is exhausted") eliminated all references
Github user eyalfa commented on the issue:
https://github.com/apache/spark/pull/21369
@advancedxy , using jvisualvm+heap dump I could see that the second
introduced test case ("drop all references to the underlying map once the
iterator is exhausted") eliminated all references to the
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90943/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21369
**[Test build #90943 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90943/testReport)**
for PR 21369 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3449/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21369
**[Test build #90943 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90943/testReport)**
for PR 21369 at commit
Github user JerryLead commented on the issue:
https://github.com/apache/spark/pull/21369
Thank you all for fixing this issue. I'm sorry that I'm now writing a
research paper about Spark GC and going to submit this paper next month. Since
there is a lot of paper work to do, the
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90861/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21369
**[Test build #90861 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90861/testReport)**
for PR 21369 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21369
**[Test build #90861 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90861/testReport)**
for PR 21369 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3392/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user eyalfa commented on the issue:
https://github.com/apache/spark/pull/21369
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90854/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21369
**[Test build #90854 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90854/testReport)**
for PR 21369 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3385/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21369
**[Test build #90854 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90854/testReport)**
for PR 21369 at commit
Github user eyalfa commented on the issue:
https://github.com/apache/spark/pull/21369
well, I took the time trying to figure out how's the iterator is eventually
being used,
(most of) it boils down to
`org.apache.spark.scheduler.ShuffleMapTask#runTask` which does:
Github user Ngone51 commented on the issue:
https://github.com/apache/spark/pull/21369
cc @JerryLead
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90832/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21369
**[Test build #90832 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90832/testReport)**
for PR 21369 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3363/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21369
**[Test build #90832 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90832/testReport)**
for PR 21369 at commit
1 - 100 of 120 matches
Mail list logo
