Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21370
@xuanyuanking Just for your reference, for this PR, the PR description can
be improved to something like
> This PR is to add eager execution into the __repr__ and _repr_html_ of
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/21370
```
Test coverage is the most critical when we refactor the existing code and
add new features. Hopefully, when you submit new PRs in the future, could you
also improve this part?
```
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21370
@xuanyuanking Thanks for your contributions! Test coverage is the most
critical when we refactor the existing code and add new features. Hopefully,
when you submit new PRs in the future, could
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21370
@xuanyuanking @HyukjinKwon Sorry for the delay. Super busy in the week of
Spark summit. Will carefully review this PR today or tomorrow.
---
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/21370
Thanks @HyukjinKwon and all reviewers.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21370
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91449/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21370
**[Test build #91449 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91449/testReport)**
for PR 21370 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3795/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21370
**[Test build #91449 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91449/testReport)**
for PR 21370 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91416/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21370
**[Test build #91416 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91416/testReport)**
for PR 21370 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3778/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21370
**[Test build #91416 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91416/testReport)**
for PR 21370 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21370
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91410/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21370
**[Test build #91410 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91410/testReport)**
for PR 21370 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3772/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21370
**[Test build #91410 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91410/testReport)**
for PR 21370 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91389/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21370
**[Test build #91389 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91389/testReport)**
for PR 21370 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3760/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21370
**[Test build #91389 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91389/testReport)**
for PR 21370 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91354/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21370
**[Test build #91354 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91354/testReport)**
for PR 21370 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3736/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21370
**[Test build #91354 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91354/testReport)**
for PR 21370 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91297/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21370
**[Test build #91297 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91297/testReport)**
for PR 21370 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3701/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21370
**[Test build #91297 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91297/testReport)**
for PR 21370 at commit
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/21370
@viirya @gatorsmile @ueshin @felixcheung @HyukjinKwon
The refactor about generating html code out of `Dataset.scala` was done in
94f3414. Please help to check whether it is appropriate
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91206/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21370
**[Test build #91206 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91206/testReport)**
for PR 21370 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3623/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21370
**[Test build #91206 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91206/testReport)**
for PR 21370 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3622/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91205/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21370
**[Test build #91205 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91205/testReport)**
for PR 21370 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21370
**[Test build #91205 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91205/testReport)**
for PR 21370 at commit
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/21370
```
Can we also do something a bit more generic that works for non-Jupyter
notebooks as well?
```
Can we accept `spark.sql.repl.eagerEval.enabled` to control both
\_\_repr\_\_ and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91022/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21370
**[Test build #91022 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91022/testReport)**
for PR 21370 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3494/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21370
**[Test build #91022 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91022/testReport)**
for PR 21370 at commit
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/21370
@rxin, `__repr__` is the equivalent for ipython and the python REPL.
`_repr_html_` is the convention used by jupyter to replicate `__repr__` in
notebooks with HTML output.
---
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/21370
Can we also do something a bit more generic that works for non-Jupyter
notebooks as well? For example, in IPython or just plain Python REPL.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90896/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21370
**[Test build #90896 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90896/testReport)**
for PR 21370 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3413/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/21370
Thanks all reviewer's comments, I address all comments in this commit.
Please have a look.
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21370
**[Test build #90896 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90896/testReport)**
for PR 21370 at commit
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/21370
So one thing we might want to take a look at is
application/vnd.dataresource+json for tables in the notebooks (see
https://github.com/nteract/improved-spark-viz ).
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90871/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21370
**[Test build #90871 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90871/testReport)**
for PR 21370 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90872/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21370
**[Test build #90872 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90872/testReport)**
for PR 21370 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3399/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21370
**[Test build #90872 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90872/testReport)**
for PR 21370 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3398/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/21370
```
this will need to escape the values to make sure it is legal html too right?
```
Yes you're right, thanks for your guidance, the new patch consider the
escape and add new UT.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21370
**[Test build #90871 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90871/testReport)**
for PR 21370 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21370
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/21370
we will wait for the tests to be fixed first.
@xuanyuanking could you update the PR description to clarify which is
"before" which is "after"?
---
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/21370
@HyukjinKwon @holdenk @ueshin
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90834/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21370
**[Test build #90834 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90834/testReport)**
for PR 21370 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3365/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21370
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21370
**[Test build #90834 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90834/testReport)**
for PR 21370 at commit
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/21370
Not sure who is the right reviewer, maybe @rdblue @gatorsmile ?
Could you help me check whether it is the right implementation for the
discussion in the dev list?
---
96 matches
Mail list logo
