Github user rxin commented on the issue:
https://github.com/apache/spark/pull/21433
Yea we can add this back easily.
On Tue, Sep 11, 2018 at 12:50 PM Sean Owen wrote:
> Given lack of certainty, and that's this is small and easy to add back in
> a different form,
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/21433
Given lack of certainty, and that's this is small and easy to add back in a
different form, and the fact that 2.4 is quickly teeing up, let me revert this
for now. We can proceed with a different
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21433
@michaelmior Since Spark 2.4 is branch cut, this PR still needs more
review. I would revert this PR from branch 2.4 and master first. We can discuss
the conf and implementation in the master
Github user michaelmior commented on the issue:
https://github.com/apache/spark/pull/21433
@gatorsmile @cloud-fan I'll just go with a boolean config as there really
is no need for more than two options and this simplifies things quite a bit.
---
Github user michaelmior commented on the issue:
https://github.com/apache/spark/pull/21433
Thanks @srowen!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/21433
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21433
**[Test build #4206 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4206/testReport)**
for PR 21433 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21433
**[Test build #4206 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4206/testReport)**
for PR 21433 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21433
**[Test build #4205 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4205/testReport)**
for PR 21433 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21433
**[Test build #4205 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4205/testReport)**
for PR 21433 at commit
Github user michaelmior commented on the issue:
https://github.com/apache/spark/pull/21433
@srowen Yes, I don't expect it will be widely used but I've personally
found it helpful in some performance debugging and it's a fairly low impact
change. I was just hoping to avoid having to
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21433
**[Test build #4203 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4203/testReport)**
for PR 21433 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21433
**[Test build #4203 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4203/testReport)**
for PR 21433 at commit
Github user michaelmior commented on the issue:
https://github.com/apache/spark/pull/21433
Rebased on top of master. The [failing test
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21433
**[Test build #4200 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4200/testReport)**
for PR 21433 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/21433
Although maybe not widely used, I could see allowing control of this via an
undocumented param
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21433
**[Test build #4200 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4200/testReport)**
for PR 21433 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21433
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user michaelmior commented on the issue:
https://github.com/apache/spark/pull/21433
Done!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21433
Could you please add the description for this PR?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21433
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21433
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
22 matches
Mail list logo
