Github user huaxingao commented on the issue:
https://github.com/apache/spark/pull/21439
Sure. I will work on it. Thanks for letting me know. @viirya
---
-
To unsubscribe, e-mail:
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21439
I think R side is not update for this yet. @huaxingao would you like to do
that?
---
-
To unsubscribe, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21439
Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21439
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21439
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94680/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21439
**[Test build #94680 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94680/testReport)**
for PR 21439 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21439
**[Test build #94680 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94680/testReport)**
for PR 21439 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21439
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21439
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94677/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21439
**[Test build #94677 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94677/testReport)**
for PR 21439 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21439
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21439
**[Test build #94677 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94677/testReport)**
for PR 21439 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21439
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21439
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94666/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21439
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21439
**[Test build #94666 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94666/testReport)**
for PR 21439 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21439
LGTM too.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21439
**[Test build #94666 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94666/testReport)**
for PR 21439 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21439
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21439
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21439
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94659/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21439
**[Test build #94659 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94659/testReport)**
for PR 21439 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21439
**[Test build #94659 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94659/testReport)**
for PR 21439 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21439
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21439
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21439
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94655/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21439
**[Test build #94655 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94655/testReport)**
for PR 21439 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21439
**[Test build #94655 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94655/testReport)**
for PR 21439 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21439
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/21439
@gatorsmile Could you look at the PR, please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/21439
@HyukjinKwon Are there any chances the PR will be merged? or I should close
it?
---
-
To unsubscribe, e-mail:
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/21439
@gatorsmile @HyukjinKwon May I ask you to look at the PR one more time.
---
-
To unsubscribe, e-mail:
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/21439
Is there anything for now which blocks the PR?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21439
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21439
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93734/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21439
**[Test build #93734 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93734/testReport)**
for PR 21439 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21439
**[Test build #93734 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93734/testReport)**
for PR 21439 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21439
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21439
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93499/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21439
**[Test build #93499 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93499/testReport)**
for PR 21439 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21439
**[Test build #93499 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93499/testReport)**
for PR 21439 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21439
cc @mgaido91 sinceI found you are not cc'ed here.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/21439
@HyukjinKwon I have a practical use case where I have json objects of any
types `struct`, `map` and `array of any types` in a column. I need the changes
to cover the use case fully.
---
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/21439
> How does it relate to #19492?
In my PR, I supported arrays of ANY types.
---
-
To unsubscribe, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21439
How does it relate to https://github.com/apache/spark/pull/19492?
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21439
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21439
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93396/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21439
**[Test build #93396 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93396/testReport)**
for PR 21439 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21439
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93393/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21439
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21439
**[Test build #93393 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93393/testReport)**
for PR 21439 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21439
**[Test build #93396 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93396/testReport)**
for PR 21439 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21439
**[Test build #93393 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93393/testReport)**
for PR 21439 at commit
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/21439
@gatorsmile @gengliangwang @maropu The change doesn't break existing
behavior. I set new option to the value which preserve backward compatibly. The
PR just extend existing implementation and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21439
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92986/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21439
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21439
**[Test build #92986 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92986/testReport)**
for PR 21439 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21439
**[Test build #92986 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92986/testReport)**
for PR 21439 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21439
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21439
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92981/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21439
**[Test build #92981 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92981/testReport)**
for PR 21439 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21439
**[Test build #92981 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92981/testReport)**
for PR 21439 at commit
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/21439
I set the option to the value which keep current behavior. So, it should be
absolutely compatibly with current implementation
---
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/21439
I guess it is still controversial to have this new behavior with the new
option.
---
-
To unsubscribe, e-mail:
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/21439
@gatorsmile Could you tell me, please, what does prevent the PR from
getting merged?
---
-
To unsubscribe, e-mail:
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/21439
@gatorsmile May I ask you to look at the PR.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21439
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21439
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92708/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21439
**[Test build #92708 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92708/testReport)**
for PR 21439 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21439
**[Test build #92708 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92708/testReport)**
for PR 21439 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21439
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92480/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21439
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21439
**[Test build #92480 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92480/testReport)**
for PR 21439 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21439
**[Test build #92480 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92480/testReport)**
for PR 21439 at commit
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/21439
@maropu @gengliangwang May I ask you to look at the PR one more time.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21439
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21439
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91874/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21439
**[Test build #91874 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91874/testReport)**
for PR 21439 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21439
**[Test build #91874 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91874/testReport)**
for PR 21439 at commit
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/21439
@maropu @gengliangwang I added SQL tests. Please, take a look at the PR
again, please.
---
-
To unsubscribe, e-mail:
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/21439
@maropu I need changes from this PR
https://github.com/apache/spark/pull/21550 (or this
https://github.com/apache/spark/pull/21472) to write SQL tests for `ArrayType`
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21439
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21439
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91668/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21439
**[Test build #91668 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91668/testReport)**
for PR 21439 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21439
**[Test build #91668 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91668/testReport)**
for PR 21439 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21439
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21439
> What kind of tests would you expect in json-functions.sql. Probably you
would expect tests
> that are different from added to JsonExpressionsSuite.scala.
IIUC there is no strict rule there
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21439
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21439
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91356/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21439
**[Test build #91356 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91356/testReport)**
for PR 21439 at commit
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/21439
@maropu For now it is impossible to specify schema for `from_json` if it is
not `StructType`. The PR https://github.com/apache/spark/pull/21472 solves the
problem.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21439
**[Test build #91356 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91356/testReport)**
for PR 21439 at commit
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/21439
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21439
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91350/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21439
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21439
**[Test build #91350 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91350/testReport)**
for PR 21439 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21439
**[Test build #91350 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91350/testReport)**
for PR 21439 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21439
cc @gengliangwang
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/21439
Thank you @maropu for your review of the PR.
> better to add tests in json-functions.sql?
What kind of tests would you expect in `json-functions.sql`. Probably you
would expect
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21439
Can we also accept primitive arrays in `to_json`?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
1 - 100 of 110 matches
Mail list logo
