Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/21459
Thanks. Merged into master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21459
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92540/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21459
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21459
**[Test build #92540 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92540/testReport)**
for PR 21459 at commit
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/21459
SGTM.
On Mon, Jul 2, 2018 at 4:38 PM DB Tsai wrote:
> There are three approvals from the committers, and the changes are pretty
> trivial to revert if we see any performance
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/21459
There are three approvals from the committers, and the changes are pretty
trivial to revert if we see any performance regression which is unlikely. To
move thing forward, if there is no further
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21459
**[Test build #4202 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4202/testReport)**
for PR 21459 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21459
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/627/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21459
**[Test build #92540 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92540/testReport)**
for PR 21459 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21459
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21459
**[Test build #4202 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4202/testReport)**
for PR 21459 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21459
**[Test build #4201 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4201/testReport)**
for PR 21459 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21459
**[Test build #4201 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4201/testReport)**
for PR 21459 at commit
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/21459
@rxin Mostly for Java 9+.
[ASM 6.x](https://mvnrepository.com/artifact/org.ow2.asm/asm/6.0/usages)
has been proven in many projects such as FB Presto, Google Guice Core Library,
CGLIB,
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/21459
What's driving this (is it java 9)? I'm in general scared by core library
updates like this. Maybe Spark 3.0 is a good time (and we should just do it
this year).
---
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/21459
@srowen From the release note, http://asm.ow2.io/versions.html , the
differences between 5.2 to 6.0 are
> Codebase migrated to gitlab (feature requests 317617, 317619, 317542)
Support
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/21459
cc @srowen and @rxin for more eyes.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/21459
@HyukjinKwon Once Spark can be built against JDK9+, we'll need to figure
out how we want to set it up in Jenkins. We can do two builds, and one for JDK8
and another one for JDK9+ for each PR, but
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21459
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21459
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91289/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21459
**[Test build #91289 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91289/testReport)**
for PR 21459 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21459
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3695/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21459
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21459
**[Test build #91289 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91289/testReport)**
for PR 21459 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21459
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21459
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21459
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91285/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21459
**[Test build #91285 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91285/testReport)**
for PR 21459 at commit
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/21459
@felixcheung Yes. All tests are passed with JDK8.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21459
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3691/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21459
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21459
**[Test build #91285 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91285/testReport)**
for PR 21459 at commit
32 matches
Mail list logo
