Github user tdas commented on the issue:
https://github.com/apache/spark/pull/21469
I did. Fixed the import
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HeartSaVioR commented on the issue:
https://github.com/apache/spark/pull/21469
@tdas In case of you are not working on the patch, I'm working on the fix
and will provide minor PR.
---
-
To unsubscribe,
Github user HeartSaVioR commented on the issue:
https://github.com/apache/spark/pull/21469
@tdas Yeah, I can check with master branch if you would like to let me
handle, and please go ahead if you would like to handle it by yourself.
---
Github user tdas commented on the issue:
https://github.com/apache/spark/pull/21469
Unfortunately this PR broke the master build. Looks like some import that
probably got removed in the other PR I merged, which didnt create any direct
conflict.
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/spark/pull/21469
Thanks all for reviewing and thanks @tdas for merging this in!
---
-
To unsubscribe, e-mail:
Github user tdas commented on the issue:
https://github.com/apache/spark/pull/21469
Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user tdas commented on the issue:
https://github.com/apache/spark/pull/21469
LGTM.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21469
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21469
**[Test build #95012 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95012/testReport)**
for PR 21469 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21469
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95012/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21469
**[Test build #95012 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95012/testReport)**
for PR 21469 at commit
Github user HeartSaVioR commented on the issue:
https://github.com/apache/spark/pull/21469
@tdas Thanks for the feedback! Updated the PR.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user tdas commented on the issue:
https://github.com/apache/spark/pull/21469
@HeartSaVioR I think I agree with a second approach that you suggested. So
`memoryUsedBytes` => `size for total memory usage of loaded versions` and
`customMetric` => `size for memory usage of
Github user HeartSaVioR commented on the issue:
https://github.com/apache/spark/pull/21469
@tdas Kindly reminder.
@zsxwing Could you take a quick look at this and share your thought? I
think the patch is ready to merge, but blocked with slightly conflict of view
so more voices
Github user HeartSaVioR commented on the issue:
https://github.com/apache/spark/pull/21469
My series of patches could be possible based on two metrics: `size for
memory usage of latest version` and `size for total memory usage of loaded
versions`. SPARK-24717 (#21700) enabled the
Github user tdas commented on the issue:
https://github.com/apache/spark/pull/21469
I am having a second thoughts about this. Exposing the entire memory usage
of all the loaded maps as another custom metric just adds more confusion.
Rather the point of the the main state metric
Github user HeartSaVioR commented on the issue:
https://github.com/apache/spark/pull/21469
@tdas Kindly reminder.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21469
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21469
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93927/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21469
**[Test build #93927 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93927/testReport)**
for PR 21469 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21469
**[Test build #93927 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93927/testReport)**
for PR 21469 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21469
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21469
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21469
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93906/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21469
**[Test build #93906 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93906/testReport)**
for PR 21469 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21469
**[Test build #93906 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93906/testReport)**
for PR 21469 at commit
Github user HeartSaVioR commented on the issue:
https://github.com/apache/spark/pull/21469
Retest this, please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21469
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93869/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21469
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21469
**[Test build #93869 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93869/testReport)**
for PR 21469 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21469
**[Test build #93869 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93869/testReport)**
for PR 21469 at commit
Github user HeartSaVioR commented on the issue:
https://github.com/apache/spark/pull/21469
@tdas Thanks for the review! Addressed review comments.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21469
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21469
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93257/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21469
**[Test build #93257 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93257/testReport)**
for PR 21469 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21469
**[Test build #93257 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93257/testReport)**
for PR 21469 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21469
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93224/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21469
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21469
**[Test build #93224 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93224/testReport)**
for PR 21469 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21469
**[Test build #93224 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93224/testReport)**
for PR 21469 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21469
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21469
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92860/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21469
**[Test build #92860 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92860/testReport)**
for PR 21469 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21469
**[Test build #92860 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92860/testReport)**
for PR 21469 at commit
Github user HeartSaVioR commented on the issue:
https://github.com/apache/spark/pull/21469
retest this, please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21469
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21469
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92839/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21469
**[Test build #92839 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92839/testReport)**
for PR 21469 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21469
**[Test build #92839 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92839/testReport)**
for PR 21469 at commit
Github user jose-torres commented on the issue:
https://github.com/apache/spark/pull/21469
Sure, I don't mind if we remove that metric.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user HeartSaVioR commented on the issue:
https://github.com/apache/spark/pull/21469
Now I'm thinking about removing "metricProviderLoaderCountOfVersionsInMap"
and also removing StateStoreCustomAverageMetric, since the value doesn't look
correct with stream-stream join which
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21469
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21469
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92551/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21469
**[Test build #92551 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92551/testReport)**
for PR 21469 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21469
**[Test build #92551 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92551/testReport)**
for PR 21469 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21469
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21469
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92544/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21469
**[Test build #92544 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92544/testReport)**
for PR 21469 at commit
Github user HeartSaVioR commented on the issue:
https://github.com/apache/spark/pull/21469
retest this, please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21469
Build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21469
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92542/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21469
**[Test build #92542 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92542/testReport)**
for PR 21469 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21469
**[Test build #92544 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92544/testReport)**
for PR 21469 at commit
Github user HeartSaVioR commented on the issue:
https://github.com/apache/spark/pull/21469
Rebased to fix conflict, and added new commit (last one: c9aada5) to
represent cache hit / miss count in HDFS state provider. This is actually
helpful for SPARK-24717 to determine proper value
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21469
**[Test build #92542 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92542/testReport)**
for PR 21469 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21469
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21469
**[Test build #92329 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92329/testReport)**
for PR 21469 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21469
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92329/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21469
**[Test build #92329 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92329/testReport)**
for PR 21469 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21469
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21469
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HeartSaVioR commented on the issue:
https://github.com/apache/spark/pull/21469
adding cc. to @zsxwing since he has been reviewing PRs for SS so far.
---
-
To unsubscribe, e-mail:
Github user HeartSaVioR commented on the issue:
https://github.com/apache/spark/pull/21469
Kindly ping again to @tdas
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21469
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91625/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21469
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21469
**[Test build #91625 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91625/testReport)**
for PR 21469 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21469
**[Test build #91625 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91625/testReport)**
for PR 21469 at commit
Github user HeartSaVioR commented on the issue:
https://github.com/apache/spark/pull/21469
@jose-torres No problem. I expect there would be some inactive moment in
Spark community during spark summit. Addressed comment regarding renaming.
---
Github user jose-torres commented on the issue:
https://github.com/apache/spark/pull/21469
(Sorry to comment after so long with such a minor change - I've been busy
with spark summit)
metricProviderLoaderMapSize should be metricProviderLoaderMapSizeBytes,
both for clarity
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21469
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21469
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91596/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21469
**[Test build #91596 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91596/testReport)**
for PR 21469 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21469
**[Test build #91596 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91596/testReport)**
for PR 21469 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21469
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21469
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21469
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91535/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21469
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21469
**[Test build #91535 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91535/testReport)**
for PR 21469 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21469
**[Test build #91535 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91535/testReport)**
for PR 21469 at commit
Github user HeartSaVioR commented on the issue:
https://github.com/apache/spark/pull/21469
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21469
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21469
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91526/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21469
**[Test build #91526 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91526/testReport)**
for PR 21469 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21469
**[Test build #91526 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91526/testReport)**
for PR 21469 at commit
Github user HeartSaVioR commented on the issue:
https://github.com/apache/spark/pull/21469
retest this, please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21469
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91523/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21469
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21469
**[Test build #91523 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91523/testReport)**
for PR 21469 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21469
**[Test build #91523 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91523/testReport)**
for PR 21469 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21469
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91509/
Test PASSed.
---
1 - 100 of 119 matches
Mail list logo
