Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21482
ping @NihalHarish
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21482
@NihalHarish shall we leave this closed for now if you don't have any
opinion on ^?
---
-
To unsubscribe, e-mail:
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/21482
OK I double checked. I don't think we should be adding this functionality,
since different databases implemented it differently, and it is somewhat
difficult to create Infinity in Spark SQL given we
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/21482
Hey I have an additional thought on this. Will leave it in the next ten
mins.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21482
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92330/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21482
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21482
**[Test build #92330 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92330/testReport)**
for PR 21482 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21482
**[Test build #92330 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92330/testReport)**
for PR 21482 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21482
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21482
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92315/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21482
**[Test build #92315 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92315/testReport)**
for PR 21482 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21482
**[Test build #92315 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92315/testReport)**
for PR 21482 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21482
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21482
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92307/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21482
**[Test build #92307 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92307/testReport)**
for PR 21482 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21482
**[Test build #92307 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92307/testReport)**
for PR 21482 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21482
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92262/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21482
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21482
**[Test build #92262 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92262/testReport)**
for PR 21482 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21482
**[Test build #92262 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92262/testReport)**
for PR 21482 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21482
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92224/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21482
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21482
**[Test build #92224 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92224/testReport)**
for PR 21482 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21482
**[Test build #92224 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92224/testReport)**
for PR 21482 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21482
I have no more comments except the one above.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user henryr commented on the issue:
https://github.com/apache/spark/pull/21482
Any further comments here?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21482
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21482
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91601/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21482
**[Test build #91601 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91601/testReport)**
for PR 21482 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21482
**[Test build #91601 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91601/testReport)**
for PR 21482 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21482
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21482
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21482
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91575/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21482
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21482
**[Test build #91575 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91575/testReport)**
for PR 21482 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21482
**[Test build #91575 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91575/testReport)**
for PR 21482 at commit
Github user henryr commented on the issue:
https://github.com/apache/spark/pull/21482
I think consistency in Spark's naming convention (and therefore increased
discoverability by users) outweighs the advantage of naming it exactly for
the Impala equivalent. I do agree that
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/21482
Thanks, Henry. In general I'm not a huge fan of adding something because
hypothetically somebody might want it. Also if you want this to be compatible
with Impala, wouldn't you want to name this the
Github user henryr commented on the issue:
https://github.com/apache/spark/pull/21482
@rxin, that in itself is a bit weird, but there are ways to express inf
values in Scala and thus inf values can show up flowing through Spark plans.
I'm not sure MySQL has any such facility.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21482
**[Test build #91518 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91518/testReport)**
for PR 21482 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21482
**[Test build #91517 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91517/testReport)**
for PR 21482 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21482
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21482
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21482
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91518/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21482
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91517/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21482
**[Test build #91518 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91518/testReport)**
for PR 21482 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21482
**[Test build #91517 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91517/testReport)**
for PR 21482 at commit
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/21482
@henryr 1.0/0.0 also returns null in Spark SQL ...
```
scala> sql("select cast(1.0 as double)/cast(0 as double)").show()
+-+
|(CAST(1.0 AS
Github user henryr commented on the issue:
https://github.com/apache/spark/pull/21482
@rxin Other engines are all over the place:
* MySQL doesn't have support for infinity (based on my cursory look) - 1.0
/ 0.0 is written as `null`. Also seems to be true of SQLite.
*
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21482
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91494/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21482
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21482
**[Test build #91494 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91494/testReport)**
for PR 21482 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21482
**[Test build #91494 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91494/testReport)**
for PR 21482 at commit
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/21482
How is this done in other databases? I don't think we want to invent new
ways on these basic primitives.
---
-
To unsubscribe,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21482
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21482
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91467/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21482
**[Test build #91467 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91467/testReport)**
for PR 21482 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21482
**[Test build #91467 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91467/testReport)**
for PR 21482 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21482
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21482
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91462/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21482
**[Test build #91462 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91462/testReport)**
for PR 21482 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21482
**[Test build #91462 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91462/testReport)**
for PR 21482 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21482
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21482
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91459/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21482
**[Test build #91459 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91459/testReport)**
for PR 21482 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21482
**[Test build #91459 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91459/testReport)**
for PR 21482 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21482
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21482
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91423/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21482
**[Test build #91423 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91423/testReport)**
for PR 21482 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21482
**[Test build #91423 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91423/testReport)**
for PR 21482 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21482
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91417/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21482
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21482
**[Test build #91417 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91417/testReport)**
for PR 21482 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21482
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21482
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91418/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21482
**[Test build #91418 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91418/testReport)**
for PR 21482 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21482
**[Test build #91418 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91418/testReport)**
for PR 21482 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21482
**[Test build #91417 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91417/testReport)**
for PR 21482 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21482
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21482
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91408/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21482
**[Test build #91408 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91408/testReport)**
for PR 21482 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21482
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21482
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91405/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21482
**[Test build #91405 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91405/testReport)**
for PR 21482 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21482
**[Test build #91408 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91408/testReport)**
for PR 21482 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21482
**[Test build #91405 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91405/testReport)**
for PR 21482 at commit
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21482
Jenkins, ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/21482
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21482
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21482
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
90 matches
Mail list logo
