Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21520
@HyukjinKwon Thanks for looking into this. It is based on the comment and
discussion here
https://github.com/apache/spark/pull/21193#discussion_r186627099.
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21520
@viirya ~ I was just trying to read the PRs. Would you please mind if I ask
where is the "Based on previous discussion" ?
---
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21520
As I will incrementally split this into smaller PRs, I will first close
this.
---
-
To unsubscribe, e-mail:
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21520
@kiszk Seems good to me. I will go to create and use those APIs in pieces
of PRs.
---
-
To unsubscribe, e-mail:
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21520
For 1, I agree with you that it is not good to introduce many APIs at
first. On the other hand, it would be good to prepare only a few APIs that are
frequently used, not to prepare many APIs. It make
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21520
> 1. We are seeing many inline prefix with a few typical patterns.
> Can we introduce new APIs to avoid repetations of adding inline, for
example JavaCode.className(Class[_]): JavaCode for the
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21520
@kiszk @mgaido91 Thanks for your comment!
> What do you think about starting doing the needed changes in smaller PRs
which focus only on specific part and forbidding the string interpolation
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/21520
yes, this is a great work @viirya ! It would be great if we can split it
into smaller updates. What do you think about starting doing the needed changes
in smaller PRs which focus only on specific
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21520
Thank you for a lot of works to update many places. It is very hard to
split it into several pieces.
Now, we are seeing several typical patterns in the all of changes, in
paticular by
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21520
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91631/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21520
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21520
**[Test build #91631 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91631/testReport)**
for PR 21520 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21520
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21520
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3884/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21520
**[Test build #91631 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91631/testReport)**
for PR 21520 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21520
Sorry this change is quite large, but it can't split into smaller pieces
because it must be changed as a whole to pass compilation.
---
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21520
cc @cloud-fan @kiszk @hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
17 matches
Mail list logo
