Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21527
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21527
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92137/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21527
**[Test build #92137 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92137/testReport)**
for PR 21527 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/21527
Also could you change the PR title to describe the change, not the problem.
"Make the threshold for highly compressed map status configurable." Or
something.
---
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/21527
+1. Leave this open for a bit to see if anyone else has comments.
---
-
To unsubscribe, e-mail:
Github user hthuynh2 commented on the issue:
https://github.com/apache/spark/pull/21527
@tgravescs I updated it. Thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21527
**[Test build #92137 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92137/testReport)**
for PR 21527 at commit
Github user hthuynh2 commented on the issue:
https://github.com/apache/spark/pull/21527
I updated it. Thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/21527
I updated the jira description @hthuynh2 please update the description on
the PR to match
---
-
To unsubscribe, e-mail:
Github user mridulm commented on the issue:
https://github.com/apache/spark/pull/21527
+1 on making this configurable.
Like @tgravescs, I dont like hardcoded constants - all for making it a
private config not necessarily exposed to users.
Will allow developers to tune it as
Github user markhamstra commented on the issue:
https://github.com/apache/spark/pull/21527
Sure, as long as we are not telling users that this is something that they
can or should use, that's fine.
---
-
To
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/21527
so I think as the pr is we don't document this config in the .md file,
other then that we need to udpate the description on the PR and jira.
@markhamstra are you ok with that? If we decide to
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21527
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91850/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21527
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21527
**[Test build #91850 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91850/testReport)**
for PR 21527 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21527
**[Test build #91850 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91850/testReport)**
for PR 21527 at commit
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/21527
test failure seems to be reported here:
https://issues.apache.org/jira/browse/SPARK-23369
---
-
To unsubscribe, e-mail:
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/21527
test this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21527
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91724/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21527
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21527
**[Test build #91724 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91724/testReport)**
for PR 21527 at commit
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21527
I'm totally onboard with exposing it, though I'd say undocumented unless we
have some concrete advice on how to set it. I was just explaining my
experience so far and why I haven't bothered with
Github user markhamstra commented on the issue:
https://github.com/apache/spark/pull/21527
> we can definitely update the description with more details.
Eventually, some of the motivation and advice/suggestions need to get into
the main user docs, as well.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21527
**[Test build #91724 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91724/testReport)**
for PR 21527 at commit
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/21527
test this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/21527
we can definitely update the description with more details.
Personally I'm not fond of any hardcoded magic number like this that you
could override with at least a internal config
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21527
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21527
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91675/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21527
**[Test build #91675 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91675/testReport)**
for PR 21527 at commit
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21527
I tell users 2001 partitions all the time. I haven't bothered trying to
make it configurable in the past because I dunno what else you'd set this value
to -- normally I think it would be better for
Github user markhamstra commented on the issue:
https://github.com/apache/spark/pull/21527
@tgravescs If there is value in making it configurable, that is all fine
and good. My argument is against making it configurable just for the sake of
making it configurable. If there is more
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21527
**[Test build #91675 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91675/testReport)**
for PR 21527 at commit
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/21527
yes it is debatable, but with it being configurable it gives you the option
to change. the only other way is to change the # of partitions which could be
more costly. There have been various
Github user markhamstra commented on the issue:
https://github.com/apache/spark/pull/21527
> We should make it configurable.
That's a debatable assertion all by itself -- and quite unfortunately,
there is no more justification for this claim in the JIRA ticket. Without proof
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21527
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21527
**[Test build #91669 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91669/testReport)**
for PR 21527 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21527
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91669/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21527
**[Test build #91669 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91669/testReport)**
for PR 21527 at commit
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/21527
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21527
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21527
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21527
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user hthuynh2 commented on the issue:
https://github.com/apache/spark/pull/21527
@tgravescs
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
43 matches
Mail list logo
