Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21529
Adding new queries to `SQLQueryTestSuite` is the best way to do it in the
current infrastructure. Do your best to cover all the join algorithms for
different input data and join types?
---
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/21529
Thanks @gatorsmile. Sorry, may I ask what you think about
https://github.com/apache/spark/pull/21529#issuecomment-396707622? Thanks.
---
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21529
Thanks! Merged to master/2.3
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91843/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21529
**[Test build #91843 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91843/testReport)**
for PR 21529 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/142/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4031/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21529
**[Test build #91843 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91843/testReport)**
for PR 21529 at commit
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/21529
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91826/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21529
**[Test build #91826 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91826/testReport)**
for PR 21529 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4018/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/129/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21529
**[Test build #91826 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91826/testReport)**
for PR 21529 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91797/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21529
**[Test build #91797 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91797/testReport)**
for PR 21529 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91790/
Test FAILed.
---
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21529
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21529
**[Test build #91790 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91790/testReport)**
for PR 21529 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21529
**[Test build #91797 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91797/testReport)**
for PR 21529 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/109/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3999/
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21529
@mgaido91 can you fix the conflicts? thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21529
**[Test build #91790 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91790/testReport)**
for PR 21529 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3995/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/104/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91773/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21529
**[Test build #91773 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91773/testReport)**
for PR 21529 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21529
LGTM except some minor comments about test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3983/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/93/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21529
**[Test build #91773 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91773/testReport)**
for PR 21529 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21529
I think for this PR, apart from the end-to-end test for checking result, we
should also have a unit test in `PlannerSuite` to cover this case. In the
followup, we can add the config support for
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/21529
> I think we need to support both. testing different physical operators
needs same result, testing something like type coercion mode needs different
result. Anyway let's discuss it in the
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21529
@mgaido91 Could you help improve the test coverage of joins
`org.apache.spark.sql.JoinSuite`? Due to the incomplete test case coverage, we
did not discover this at the very beginning. We need
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21529
I think we need to support both. testing different physical operators needs
same result, testing something like type coercion mode needs different result.
Anyway let's discuss it in the followup.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91710/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21529
**[Test build #91710 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91710/testReport)**
for PR 21529 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21529
**[Test build #91710 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91710/testReport)**
for PR 21529 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/46/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3936/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91705/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21529
**[Test build #91705 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91705/testReport)**
for PR 21529 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3932/
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/21529
thanks for your review @cloud-fan. Nice catch on the `transformUp`! I
addressed all your comments.
As far as the followup is regarded, we should decide if we want to support
the
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21529
**[Test build #91705 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91705/testReport)**
for PR 21529 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/42/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21529
one followup: we should improve our golden file sql test, to run same
queries with different configs. This is pretty important for the join tests,
otherwise we only test broadcast join.
---
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21529
I was surprised that this bug is present even if the table is not bucketed,
and then I found out another problem in the code: `reorderJoinPredicates`
transform the plan again.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91666/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21529
**[Test build #91666 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91666/testReport)**
for PR 21529 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21529
good catch! thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3904/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21529
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21529
**[Test build #91666 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91666/testReport)**
for PR 21529 at commit
79 matches
Mail list logo
