[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21596 **[Test build #92209 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92209/testReport)** for PR 21596 at commit

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-22 Thread Fokko
Github user Fokko commented on the issue: https://github.com/apache/spark/pull/21596 I've pushed the changes, the tests are still running locally. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-22 Thread Fokko
Github user Fokko commented on the issue: https://github.com/apache/spark/pull/21596 Yes, let me add it. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21596 @Fokko, mind adding the test described in #20738 here too? --- - To unsubscribe, e-mail:

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21596 @cxzl25, 2.7.x has a regression so we had to revert it back. Please see https://github.com/apache/spark/pull/9759. --- - To

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-22 Thread cxzl25
Github user cxzl25 commented on the issue: https://github.com/apache/spark/pull/21596 https://github.com/apache/spark/pull/20738 Bump jackson from 2.6.7&2.6.7.1 to 2.7.7 Jackson(>=2.7.7) fixes the possibility of missing tail data when the length of the value is in a range

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-21 Thread MaxGekk
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/21596 Please, make sure that performance doesn't degrade after upgrading Jackson. You can check that by

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21596 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92166/ Test FAILed. ---

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21596 **[Test build #92166 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92166/testReport)** for PR 21596 at commit

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21596 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21596 **[Test build #92166 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92166/testReport)** for PR 21596 at commit

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-21 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21596 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-21 Thread Fokko
Github user Fokko commented on the issue: https://github.com/apache/spark/pull/21596 I could not get the tests working locally. :-) Let me give it another try. --- - To unsubscribe, e-mail:

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-20 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21596 I tried this in my local too. I didn't mean that we shouldn't but let's fix the test cases and address other concerns. ---

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-20 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/21596 Which is, btw, a way of saying you should run `dev/run-tests` locally, at least, when changing a dependency. --- - To

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-20 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/21596 I agree we should upgrade, but just changing the pom version will not work. I have an internal patch for this and I needed small changes in a few other places... ---

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-20 Thread Fokko
Github user Fokko commented on the issue: https://github.com/apache/spark/pull/21596 This was more than a year ago, we should eventually upgrade.. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-20 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21596 The tests will be already failed given my tries before and there are many concerns about this. Also see and address the concerns in https://github.com/apache/spark/pull/9759. ---

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21596 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21596 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21596 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

<    1   2   3