Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21608
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21608
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21608
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94397/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21608
**[Test build #94397 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94397/testReport)**
for PR 21608 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21608
**[Test build #94397 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94397/testReport)**
for PR 21608 at commit
Github user Achuth17 commented on the issue:
https://github.com/apache/spark/pull/21608
@maropu @gatorsmile, Any other changes required?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21608
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21608
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94259/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21608
**[Test build #94259 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94259/testReport)**
for PR 21608 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21608
**[Test build #94259 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94259/testReport)**
for PR 21608 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21608
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user Achuth17 commented on the issue:
https://github.com/apache/spark/pull/21608
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user Achuth17 commented on the issue:
https://github.com/apache/spark/pull/21608
@maropu @gatorsmile The tests are failing in places unrelated to my
changes. How can I resolve this?
---
-
To unsubscribe,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21608
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21608
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94167/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21608
**[Test build #94167 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94167/testReport)**
for PR 21608 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21608
**[Test build #94167 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94167/testReport)**
for PR 21608 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21608
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21608
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94043/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21608
**[Test build #94043 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94043/testReport)**
for PR 21608 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21608
**[Test build #94043 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94043/testReport)**
for PR 21608 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21608
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93944/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21608
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21608
**[Test build #93944 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93944/testReport)**
for PR 21608 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21608
**[Test build #93944 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93944/testReport)**
for PR 21608 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21608
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21608
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93905/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21608
**[Test build #93905 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93905/testReport)**
for PR 21608 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21608
**[Test build #93905 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93905/testReport)**
for PR 21608 at commit
Github user Achuth17 commented on the issue:
https://github.com/apache/spark/pull/21608
@gatorsmile, I have addressed the comments. Any other fix required?
---
-
To unsubscribe, e-mail:
Github user Achuth17 commented on the issue:
https://github.com/apache/spark/pull/21608
@gatorsmile, I have made the changes.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21608
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21608
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93731/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21608
**[Test build #93731 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93731/testReport)**
for PR 21608 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21608
**[Test build #93731 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93731/testReport)**
for PR 21608 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21608
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93710/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21608
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21608
**[Test build #93710 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93710/testReport)**
for PR 21608 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21608
**[Test build #93710 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93710/testReport)**
for PR 21608 at commit
Github user Achuth17 commented on the issue:
https://github.com/apache/spark/pull/21608
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21608
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93702/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21608
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21608
**[Test build #93702 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93702/testReport)**
for PR 21608 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21608
**[Test build #93702 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93702/testReport)**
for PR 21608 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21608
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21608
**[Test build #93701 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93701/testReport)**
for PR 21608 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21608
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93701/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21608
**[Test build #93701 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93701/testReport)**
for PR 21608 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21608
Build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21608
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93700/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21608
**[Test build #93700 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93700/testReport)**
for PR 21608 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21608
**[Test build #93700 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93700/testReport)**
for PR 21608 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21608
Also make it configurable. At least, users can turn this feature off.
---
-
To unsubscribe, e-mail:
Github user Achuth17 commented on the issue:
https://github.com/apache/spark/pull/21608
@gatorsmile Can you review this please? Thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21608
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93507/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21608
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21608
**[Test build #93507 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93507/testReport)**
for PR 21608 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21608
**[Test build #93507 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93507/testReport)**
for PR 21608 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21608
LGTM except for minor comments
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user Achuth17 commented on the issue:
https://github.com/apache/spark/pull/21608
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21608
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21608
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93475/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21608
**[Test build #93475 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93475/testReport)**
for PR 21608 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21608
**[Test build #93475 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93475/testReport)**
for PR 21608 at commit
Github user Achuth17 commented on the issue:
https://github.com/apache/spark/pull/21608
@gatorsmile @maropu ping.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21608
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21608
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93377/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21608
**[Test build #93377 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93377/testReport)**
for PR 21608 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21608
**[Test build #93377 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93377/testReport)**
for PR 21608 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21608
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21608
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93352/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21608
**[Test build #93352 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93352/testReport)**
for PR 21608 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21608
ping me next week. I will review this again. Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21608
**[Test build #93352 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93352/testReport)**
for PR 21608 at commit
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/21608
Jenkins retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user Achuth17 commented on the issue:
https://github.com/apache/spark/pull/21608
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21608
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21608
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93262/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21608
**[Test build #93262 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93262/testReport)**
for PR 21608 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21608
**[Test build #93262 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93262/testReport)**
for PR 21608 at commit
Github user Achuth17 commented on the issue:
https://github.com/apache/spark/pull/21608
@maropu @gatorsmile Can you review this? Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/21608
Maybe @ericl has some cycles?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user Achuth17 commented on the issue:
https://github.com/apache/spark/pull/21608
Ping @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21608
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92949/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21608
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21608
**[Test build #92949 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92949/testReport)**
for PR 21608 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21608
**[Test build #92949 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92949/testReport)**
for PR 21608 at commit
Github user Achuth17 commented on the issue:
https://github.com/apache/spark/pull/21608
@maropu I have added a simple test, Can you check it out?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21608
you'd be better to do that. cc: @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21608
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21608
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92888/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21608
**[Test build #92888 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92888/testReport)**
for PR 21608 at commit
Github user Achuth17 commented on the issue:
https://github.com/apache/spark/pull/21608
@maropu, The method `calculateTotalSize` is already tested in
`StatisticsSuite` in a few places. One such test is "analyze Hive serde tables"
where we check to make sure the calculated size of the
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21608
**[Test build #92888 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92888/testReport)**
for PR 21608 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21608
I think it's ok to put tests in `CommandUtilsSuite`.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user Achuth17 commented on the issue:
https://github.com/apache/spark/pull/21608
@maropu regarding tests, since I didn't make any changes to
`inMemoryFileIndex` isn't it better if I added tests in
StatisticsCollectionSuite/StatisticsSuite?
Also, since we just
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21608
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21608
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92835/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21608
**[Test build #92835 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92835/testReport)**
for PR 21608 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21608
Super nit though, I think you'd be better to put the performance values in
the section `What changes were proposed in this pull request?` instead of the
new `Results` section in the pr description.
1 - 100 of 124 matches
Mail list logo