[GitHub] spark issue #21610: Updates to LICENSE and NOTICE

2018-07-31 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/21610 BTW I think this can be closed. I separately overhauled the LICENSE/NOTICE. --- - To unsubscribe, e-mail:

[GitHub] spark issue #21610: Updates to LICENSE and NOTICE

2018-06-26 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/21610 Justin can you be more specific? I'm looking at our last binary release and it certainly has (what appear to be) all of Spark's transitive dependencies in jars/. What are you seeing? ---

[GitHub] spark issue #21610: Updates to LICENSE and NOTICE

2018-06-26 Thread justinmclean
Github user justinmclean commented on the issue: https://github.com/apache/spark/pull/21610 Nope they are not. It's best to inspect the binaries by hand and see what is actually bundled. --- - To unsubscribe,

[GitHub] spark issue #21610: Updates to LICENSE and NOTICE

2018-06-26 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/21610 Certainly. I'm saying that these are nearly the same thing, because the binary release is, mostly, a collection of compiled Spark code and all its transitive dependencies. This is why it's correct

[GitHub] spark issue #21610: Updates to LICENSE and NOTICE

2018-06-26 Thread justinmclean
Github user justinmclean commented on the issue: https://github.com/apache/spark/pull/21610 Just to be clear it's not dependancies that need to be listed only what is actually bundled in the release artefact. --- -

[GitHub] spark issue #21610: Updates to LICENSE and NOTICE

2018-06-25 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/21610 Oh I missed this: "Attribution is required (in a similar fashion to permissive licenses)." Hm, I wonder why (other than being nice). But it's easy enough to revise this to attribute several other

[GitHub] spark issue #21610: Updates to LICENSE and NOTICE

2018-06-25 Thread justinmclean
Github user justinmclean commented on the issue: https://github.com/apache/spark/pull/21610 You'll note on that link you give that public domain or CC0 licenced bits should be treated the same way as other permissive licenced software like MIT or BSD. i.e you add the text of

[GitHub] spark issue #21610: Updates to LICENSE and NOTICE

2018-06-23 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/21610 OK if you want to pare down the PR to fixes we had discussed here and on the thread, I can get it in. I will need to just reevaluate the whole LICENSE and NOTICE anyway as it's clear it's at least a

[GitHub] spark issue #21610: Updates to LICENSE and NOTICE

2018-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21610 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92252/ Test PASSed. ---

[GitHub] spark issue #21610: Updates to LICENSE and NOTICE

2018-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21610 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21610: Updates to LICENSE and NOTICE

2018-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21610 **[Test build #92252 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92252/testReport)** for PR 21610 at commit

[GitHub] spark issue #21610: Updates to LICENSE and NOTICE

2018-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21610 **[Test build #92252 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92252/testReport)** for PR 21610 at commit

[GitHub] spark issue #21610: Updates to LICENSE and NOTICE

2018-06-23 Thread justinmclean
Github user justinmclean commented on the issue: https://github.com/apache/spark/pull/21610 Yes it 's trying to correct if for the source release. As per the guiding principle [1] the LICENSE and NOTICE needs to represent what in the release this often mean you get different LICENSE

[GitHub] spark issue #21610: Updates to LICENSE and NOTICE

2018-06-23 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/21610 Is this patch trying to make this into LICENSE/NOTICE appropriate for a source release? then they wouldn't work for a binary release. Maybe we can - address any gaps in the binary release

[GitHub] spark issue #21610: Updates to LICENSE and NOTICE

2018-06-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21610 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92199/ Test FAILed. ---

[GitHub] spark issue #21610: Updates to LICENSE and NOTICE

2018-06-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21610 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21610: Updates to LICENSE and NOTICE

2018-06-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21610 **[Test build #92199 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92199/testReport)** for PR 21610 at commit

[GitHub] spark issue #21610: Updates to LICENSE and NOTICE

2018-06-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21610 **[Test build #92199 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92199/testReport)** for PR 21610 at commit

[GitHub] spark issue #21610: Updates to LICENSE and NOTICE

2018-06-22 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/21610 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21610: Updates to LICENSE and NOTICE

2018-06-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21610 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21610: Updates to LICENSE and NOTICE

2018-06-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21610 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21610: Updates to LICENSE and NOTICE

2018-06-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21610 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional