Github user srowen commented on the issue:
https://github.com/apache/spark/pull/21638
Ideally the last test should have 50 partitions? is it because we really
need the test data to be at least 50 bytes? ideally a multiple of 50, I guess.
---
Github user bomeng commented on the issue:
https://github.com/apache/spark/pull/21638
Here is the test code, not sure it is right or not ---
```
test("Number of partitions") {
sc = new SparkContext(new
SparkConf().setAppName("test").setMaster("local")
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21638
Yea, let's add a regression test.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21638
@bomeng Could you submit a follow-up PR to add a test case?
---
-
To unsubscribe, e-mail:
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/21638
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21638
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95295/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21638
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21638
**[Test build #95295 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95295/testReport)**
for PR 21638 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21638
**[Test build #95295 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95295/testReport)**
for PR 21638 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21638
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21638
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21638
**[Test build #4290 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4290/testReport)**
for PR 21638 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21638
**[Test build #4290 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4290/testReport)**
for PR 21638 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21638
Yea, it's internal to Spark. Might be good to keep it but that concern
should be secondary IMHO.
---
-
To unsubscribe,
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/21638
Except for `binaryFiles`, everything else that needs to change is private
to Spark. I know it's public in the bytecode, but only Java callers could
accidentally exploit that. Still I don't
Github user bomeng commented on the issue:
https://github.com/apache/spark/pull/21638
Either way works for me, but I think since this is not a private method, so
people may use it in their own approach. The minimal change will be the best.
---
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/21638
Because this method is internal to Spark, why not just take out the
parameter? Yes it's superfluous now, but it's been this way for a while, and
seems perhaps better to avoid a behavior change. In
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21638
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21638
**[Test build #93067 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93067/testReport)**
for PR 21638 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21638
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/983/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21638
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21638
**[Test build #93067 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93067/testReport)**
for PR 21638 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21638
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user bomeng commented on the issue:
https://github.com/apache/spark/pull/21638
@HyukjinKwon please review. thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21638
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21638
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92350/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21638
**[Test build #92350 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92350/testReport)**
for PR 21638 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21638
**[Test build #92350 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92350/testReport)**
for PR 21638 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21638
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/490/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21638
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21638
Not sure yet but let's leave that out of this PR.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/21638
It seems there is similar code there:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21638
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21638
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92309/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21638
**[Test build #92309 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92309/testReport)**
for PR 21638 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21638
**[Test build #92309 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92309/testReport)**
for PR 21638 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21638
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21638
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/464/
38 matches
Mail list logo
