Github user srowen commented on the issue:
https://github.com/apache/spark/pull/21672
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21672
@foxish @srowen gentle ping.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21672
@felixcheung I think its ok to merge. In the future when we will add tests
passing more params we can verify it easily, but it is better than before.
---
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21672
@felixcheung we could call a test with more than one parameters like:
https://github.com/apache/spark/blob/master/examples/src/main/scala/org/apache/spark/examples/MultiBroadcastTest.scala
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21672
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21672
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/594/
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21672
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/594/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21672
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92489/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21672
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/594/
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21672
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21672
**[Test build #92489 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92489/testReport)**
for PR 21672 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21672
**[Test build #92489 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92489/testReport)**
for PR 21672 at commit
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21672
@vanzin @ssuchter removed the condition, I think its ok now.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21672
@ssuchter yes if you check the jira, the old behavior does not work with
more than one args. In the future might be a problem.
---
Github user ssuchter commented on the issue:
https://github.com/apache/spark/pull/21672
BTW, for committers - I think this patch is good to merge.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user ssuchter commented on the issue:
https://github.com/apache/spark/pull/21672
I see why the old behavior was there. I made a minimal change to some
existing code to fix a bug:
https://github.com/ssuchter/spark/commit/1d8a265d13b65dcec8db11a5be09d4a029037d2c
Github user ssuchter commented on the issue:
https://github.com/apache/spark/pull/21672
So this changes behavior, I think. In the old behavior, if the args were
['a', 'b'] then you'd get a single arg of ['a b'] passed through, and with this
you'd get ['a', 'b'].
This new
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21672
@ssuchter @liyinan926 psl review. This is trivial, unless I am missing
something.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21672
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92483/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21672
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21672
**[Test build #92483 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92483/testReport)**
for PR 21672 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21672
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21672
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/590/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21672
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/590/
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21672
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/590/
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21672
**[Test build #92483 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92483/testReport)**
for PR 21672 at commit
26 matches
Mail list logo
