[GitHub] spark issue #21687: [SPARK-24165][SQL] Fixing the output data type of CaseWh...

2018-07-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21687 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92535/ Test PASSed. ---

[GitHub] spark issue #21687: [SPARK-24165][SQL] Fixing the output data type of CaseWh...

2018-07-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21687 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21687: [SPARK-24165][SQL] Fixing the output data type of CaseWh...

2018-07-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21687 **[Test build #92535 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92535/testReport)** for PR 21687 at commit

[GitHub] spark issue #21687: [SPARK-24165][SQL] Fixing the output data type of CaseWh...

2018-07-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21687 **[Test build #92535 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92535/testReport)** for PR 21687 at commit

[GitHub] spark issue #21687: [SPARK-24165][SQL] Fixing the output data type of CaseWh...

2018-07-02 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21687 IMHO we need the same fix for both cases. Also, I like simpler implementations in expressions, so IMO it'd be better to fix in analysis phases. ---

[GitHub] spark issue #21687: [SPARK-24165][SQL] Fixing the output data type of CaseWh...

2018-07-02 Thread mn-mikke
Github user mn-mikke commented on the issue: https://github.com/apache/spark/pull/21687 @viirya Yeah, it looks like the same problem, but It's worked around via different implementation of ```IfCoercion``` rule. This rule utilizes ```!=``` operator for comparison. So if two types

[GitHub] spark issue #21687: [SPARK-24165][SQL] Fixing the output data type of CaseWh...

2018-07-02 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/21687 Seems `If` has similar issue? ```scala case class If(predicate: Expression, trueValue: Expression, falseValue: Expression) extends Expression { ... override def dataType:

[GitHub] spark issue #21687: [SPARK-24165][SQL] Fixing the output data type of CaseWh...

2018-07-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21687 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92513/ Test PASSed. ---

[GitHub] spark issue #21687: [SPARK-24165][SQL] Fixing the output data type of CaseWh...

2018-07-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21687 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21687: [SPARK-24165][SQL] Fixing the output data type of CaseWh...

2018-07-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21687 **[Test build #92513 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92513/testReport)** for PR 21687 at commit

[GitHub] spark issue #21687: [SPARK-24165][SQL] Fixing the output data type of CaseWh...

2018-07-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21687 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21687: [SPARK-24165][SQL] Fixing the output data type of CaseWh...

2018-07-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21687 **[Test build #92513 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92513/testReport)** for PR 21687 at commit

[GitHub] spark issue #21687: [SPARK-24165][SQL] Fixing the output data type of CaseWh...

2018-07-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21687 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional