Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21729
For other reviewers, this is merged to master/2.3
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/21729
+1 I'm going to merge, thanks @hthuynh2
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21729
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21729
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93249/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21729
**[Test build #93249 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93249/testReport)**
for PR 21729 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21729
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21729
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93248/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21729
**[Test build #93248 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93248/testReport)**
for PR 21729 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21729
**[Test build #93249 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93249/testReport)**
for PR 21729 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21729
**[Test build #93248 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93248/testReport)**
for PR 21729 at commit
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21729
lgtm
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user mridulm commented on the issue:
https://github.com/apache/spark/pull/21729
Looks good to me, thanks for fixing this @hthuynh2 !
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21729
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93176/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21729
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21729
**[Test build #93176 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93176/testReport)**
for PR 21729 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21729
**[Test build #93176 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93176/testReport)**
for PR 21729 at commit
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/21729
test this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21729
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21729
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93127/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21729
**[Test build #93127 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93127/testReport)**
for PR 21729 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21729
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21729
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93121/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21729
**[Test build #93121 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93121/testReport)**
for PR 21729 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21729
**[Test build #93127 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93127/testReport)**
for PR 21729 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21729
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93122/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21729
**[Test build #93121 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93121/testReport)**
for PR 21729 at commit
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/21729
@hthuynh2 please update based on the comments above. You can leave the
type as Hashset and fix the other typos, identations, and comments.
---
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/21729
cc @mridulm
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21729
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92775/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21729
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21729
**[Test build #92775 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92775/testReport)**
for PR 21729 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21729
**[Test build #92775 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92775/testReport)**
for PR 21729 at commit
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/21729
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user hthuynh2 commented on the issue:
https://github.com/apache/spark/pull/21729
@xuanyuanking Thanks for the comments. I also thought about modifying the
UT of SPARK-22074 instead of adding new UT but I was afraid it might cause
confusing since they are 2 different issues
34 matches
Mail list logo
