Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #93762 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93762/testReport)**
for PR 21732 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21732
This PR is just a special handling for `Option[Product]` in Aggregator, I
think we don't need it when we have the more general solution, right?
---
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21732
@cloud-fan We can. Just wondering if you think it is good to have that in
this PR too?
---
-
To unsubscribe, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21732
Again, can we always support `Option[Product]` with some special handling
for top-level encoder expression?
---
-
To
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21732
ping @cloud-fan @hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21732
At the end of encoder creation? You mean at the end of calling
`ExpressionEncoder.apply()`? But it is used both for top-level encoder e.g.,
`Dataset[Option[Product]]` and non top-level encoder
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21732
> Non top-level and top-level encoders for Option[Product] have a little
difference.
Can we treat them the same but at the end of encoder creation, we flatten
the `Option[Product]`?
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21732
ping @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21732
Non top-level and top-level encoders for `Option[Product]` have a little
difference.
As you said, top-level `Option[Product]` can only be encoded as a single
struct column.
For non
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21732
yes it is, but it makes the encoder framework more consistent. And making a
failure case into runnable is a safe behavior change.
---
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21732
It sounds like much more behavior changing?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21732
how about we treat the top level `Option[Product]` as a single struct
column? then we can git rid of this limitation entirely.
---
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21732
cc @cloud-fan @hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21732
I'm wondering should we add encoders of Option of Product into object
`Encoders`.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92748/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #92748 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92748/testReport)**
for PR 21732 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/772/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #92748 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92748/testReport)**
for PR 21732 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21732
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92739/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #92739 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92739/testReport)**
for PR 21732 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/765/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #92739 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92739/testReport)**
for PR 21732 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21732
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92729/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #92729 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92729/testReport)**
for PR 21732 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #92729 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92729/testReport)**
for PR 21732 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/759/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
36 matches
Mail list logo
