Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21747
Thank you for the decision, @mn-mikke and @cloud-fan !
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21747
To backport this fix, we need to backport another improvement PR that
allows accessing SQLConf at executor side, which violates the backport rule. I
think it's ok to have this fix in 2.4 only.
Github user mn-mikke commented on the issue:
https://github.com/apache/spark/pull/21747
If nobody has any objections, I'm happy to close this PR.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21747
Hi, @mn-mikke and @cloud-fan and @maropu .
2.3.2 vote passed today and 2.4.0-rc1 doesn't have this issue. Given that
Spark 2.4.0 will come faster than Spark 2.3.3, are we heading to (1) or
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21747
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21747
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92933/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21747
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21747
**[Test build #92933 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92933/testReport)**
for PR 21747 at commit
Github user mn-mikke commented on the issue:
https://github.com/apache/spark/pull/21747
IMHO, we could directly use ```DataType.equalsIgnoreCaseAndNullability```
instead of ```sameType``` to make sure that ```mergeTwoDataTypes``` won't blow
up if the trait is misused. The proper
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21747
**[Test build #92933 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92933/testReport)**
for PR 21747 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21747
How about making a temporary helper function for `sameType` in
`ComplexTypeMergingExpression`? You read the config for case sensitivity in a
driver side, and hold it as a field value in the closure.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21747
ah, that's hard to fix, maybe just leave it, since Spark 2.4 is coming.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21747
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92925/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21747
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21747
**[Test build #92925 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92925/testReport)**
for PR 21747 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21747
**[Test build #92925 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92925/testReport)**
for PR 21747 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21747
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21747
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92914/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21747
**[Test build #92914 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92914/testReport)**
for PR 21747 at commit
Github user mn-mikke commented on the issue:
https://github.com/apache/spark/pull/21747
Thanks guys for triggering the builds, but I must implement a fix first.
It's failing since the code is accessing ```SQLConf``` from executors
(```doCodeGen```->
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21747
**[Test build #92914 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92914/testReport)**
for PR 21747 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21747
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21747
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21747
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92912/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21747
**[Test build #92912 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92912/testReport)**
for PR 21747 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21747
**[Test build #92912 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92912/testReport)**
for PR 21747 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21747
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21747
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21747
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92862/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21747
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21747
**[Test build #92862 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92862/testReport)**
for PR 21747 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21747
**[Test build #92862 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92862/testReport)**
for PR 21747 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21747
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21747
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92859/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21747
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21747
**[Test build #92859 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92859/testReport)**
for PR 21747 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21747
**[Test build #92859 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92859/testReport)**
for PR 21747 at commit
Github user mn-mikke commented on the issue:
https://github.com/apache/spark/pull/21747
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21747
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92856/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21747
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21747
**[Test build #92856 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92856/testReport)**
for PR 21747 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21747
**[Test build #92856 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92856/testReport)**
for PR 21747 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21747
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21747
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user mn-mikke commented on the issue:
https://github.com/apache/spark/pull/21747
cc @cloud-fan @ueshin @viirya @maropu
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
45 matches
Mail list logo
