[GitHub] spark issue #21756: [SPARK-24764] [CORE] Add ServiceLoader implementation fo...

2018-09-14 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/21756 Only you can close your own PR. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #21756: [SPARK-24764] [CORE] Add ServiceLoader implementation fo...

2018-09-14 Thread shrutig
Github user shrutig commented on the issue: https://github.com/apache/spark/pull/21756 Thank you for your feedback. I have created a separate JIRA https://issues.apache.org/jira/browse/SPARK-25428 to track Spark support for plain Kerberos authentication. Hence, this PR can be closed.

[GitHub] spark issue #21756: [SPARK-24764] [CORE] Add ServiceLoader implementation fo...

2018-09-07 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/21756 I really dislike exposing this a something that others can override. We should be going the other way, and making that code as generic as possible. If there's something that you can fix in

[GitHub] spark issue #21756: [SPARK-24764] [CORE] Add ServiceLoader implementation fo...

2018-09-04 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/21756 I think the use case here is quite specific, I'm not sure if it is a good idea to make `SparkHadoopUtil` ServiceLoader-able to support your requirement. Typically I don't think user has a such

[GitHub] spark issue #21756: [SPARK-24764] [CORE] Add ServiceLoader implementation fo...

2018-09-04 Thread dbtsai
Github user dbtsai commented on the issue: https://github.com/apache/spark/pull/21756 add @jerryshao for more feedback. Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21756: [SPARK-24764] [CORE] Add ServiceLoader implementation fo...

2018-09-04 Thread shrutig
Github user shrutig commented on the issue: https://github.com/apache/spark/pull/21756 @dbtsai @vanzin What we are trying to achieve is to make Spark work with plain Kerberos authentication. We `login user from keytab` at the startup of driver and executors and then use

[GitHub] spark issue #21756: [SPARK-24764] [CORE] Add ServiceLoader implementation fo...

2018-08-22 Thread dbtsai
Github user dbtsai commented on the issue: https://github.com/apache/spark/pull/21756 From what I talked to @shrutig offline, the use-case her team has is when `UserGroupInformation.getCurrentUser.getAuthenticationMethod == AuthenticationMethod.KERBEROS`, they want to set the remote

[GitHub] spark issue #21756: [SPARK-24764] [CORE] Add ServiceLoader implementation fo...

2018-08-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21756 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21756: [SPARK-24764] [CORE] Add ServiceLoader implementation fo...

2018-08-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21756 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95049/ Test PASSed. ---

[GitHub] spark issue #21756: [SPARK-24764] [CORE] Add ServiceLoader implementation fo...

2018-08-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21756 **[Test build #95049 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95049/testReport)** for PR 21756 at commit

[GitHub] spark issue #21756: [SPARK-24764] [CORE] Add ServiceLoader implementation fo...

2018-08-21 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/21756 I don't understand the purpose of this change. Can you explain exactly what part of `SparkHadoopUtil` do you need to customize, and why that change can't just be made to the shared code?

[GitHub] spark issue #21756: [SPARK-24764] [CORE] Add ServiceLoader implementation fo...

2018-08-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21756 **[Test build #95049 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95049/testReport)** for PR 21756 at commit

[GitHub] spark issue #21756: [SPARK-24764] [CORE] Add ServiceLoader implementation fo...

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21756 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93856/ Test PASSed. ---

[GitHub] spark issue #21756: [SPARK-24764] [CORE] Add ServiceLoader implementation fo...

2018-08-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21756 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21756: [SPARK-24764] [CORE] Add ServiceLoader implementation fo...

2018-08-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21756 **[Test build #93856 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93856/testReport)** for PR 21756 at commit

[GitHub] spark issue #21756: [SPARK-24764] [CORE] Add ServiceLoader implementation fo...

2018-07-31 Thread shrutig
Github user shrutig commented on the issue: https://github.com/apache/spark/pull/21756 `SparkHadoopUtil` is accessed in multiple points in Apache Spark , and is not limited to usage by yarn. External cluster managers should also be able to change any functions in `SparkHadoopUtil`,

[GitHub] spark issue #21756: [SPARK-24764] [CORE] Add ServiceLoader implementation fo...

2018-07-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21756 **[Test build #93856 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93856/testReport)** for PR 21756 at commit

[GitHub] spark issue #21756: [SPARK-24764] [CORE] Add ServiceLoader implementation fo...

2018-07-16 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/21756 Would you please explain the scenarios of such usage? This `SparkHadoopUtil` is highly hadoop/yarn dependent, I'm not sure how other customized cluster manager use it? ---

[GitHub] spark issue #21756: [SPARK-24764] [CORE] Add ServiceLoader implementation fo...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21756 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92944/ Test FAILed. ---

[GitHub] spark issue #21756: [SPARK-24764] [CORE] Add ServiceLoader implementation fo...

2018-07-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21756 **[Test build #92944 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92944/testReport)** for PR 21756 at commit

[GitHub] spark issue #21756: [SPARK-24764] [CORE] Add ServiceLoader implementation fo...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21756 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21756: [SPARK-24764] [CORE] Add ServiceLoader implementation fo...

2018-07-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21756 **[Test build #92944 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92944/testReport)** for PR 21756 at commit

[GitHub] spark issue #21756: [SPARK-24764] [CORE] Add ServiceLoader implementation fo...

2018-07-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21756 **[Test build #92940 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92940/testReport)** for PR 21756 at commit

[GitHub] spark issue #21756: [SPARK-24764] [CORE] Add ServiceLoader implementation fo...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21756 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92940/ Test FAILed. ---

[GitHub] spark issue #21756: [SPARK-24764] [CORE] Add ServiceLoader implementation fo...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21756 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21756: [SPARK-24764] [CORE] Add ServiceLoader implementation fo...

2018-07-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21756 **[Test build #92940 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92940/testReport)** for PR 21756 at commit

[GitHub] spark issue #21756: [SPARK-24764] [CORE] Add ServiceLoader implementation fo...

2018-07-12 Thread dbtsai
Github user dbtsai commented on the issue: https://github.com/apache/spark/pull/21756 Jenkins, ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21756: [SPARK-24764] [CORE] Add ServiceLoader implementation fo...

2018-07-12 Thread dbtsai
Github user dbtsai commented on the issue: https://github.com/apache/spark/pull/21756 add to whitelist --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21756: [SPARK-24764] [CORE] Add ServiceLoader implementation fo...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21756 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21756: [SPARK-24764] [CORE] Add ServiceLoader implementation fo...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21756 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21756: [SPARK-24764] [CORE] Add ServiceLoader implementation fo...

2018-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21756 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional