[GitHub] spark issue #21807: [SPARK-24536] Validate that limit clause cannot have a n...

2018-07-31 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/21807 @mauropalsgraaf Could you fix the PR title? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21807: [SPARK-24536] Validate that limit clause cannot have a n...

2018-07-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21807 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93817/ Test PASSed. ---

[GitHub] spark issue #21807: [SPARK-24536] Validate that limit clause cannot have a n...

2018-07-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21807 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21807: [SPARK-24536] Validate that limit clause cannot have a n...

2018-07-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21807 **[Test build #93817 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93817/testReport)** for PR 21807 at commit

[GitHub] spark issue #21807: [SPARK-24536] Validate that limit clause cannot have a n...

2018-07-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21807 **[Test build #93817 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93817/testReport)** for PR 21807 at commit

[GitHub] spark issue #21807: [SPARK-24536] Validate that limit clause cannot have a n...

2018-07-30 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21807 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21807: [SPARK-24536] Validate that limit clause cannot have a n...

2018-07-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21807 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93805/ Test FAILed. ---

[GitHub] spark issue #21807: [SPARK-24536] Validate that limit clause cannot have a n...

2018-07-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21807 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21807: [SPARK-24536] Validate that limit clause cannot have a n...

2018-07-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21807 **[Test build #93805 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93805/testReport)** for PR 21807 at commit

[GitHub] spark issue #21807: [SPARK-24536] Validate that limit clause cannot have a n...

2018-07-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21807 **[Test build #93805 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93805/testReport)** for PR 21807 at commit

[GitHub] spark issue #21807: [SPARK-24536] Validate that limit clause cannot have a n...

2018-07-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21807 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93787/ Test PASSed. ---

[GitHub] spark issue #21807: [SPARK-24536] Validate that limit clause cannot have a n...

2018-07-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21807 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21807: [SPARK-24536] Validate that limit clause cannot have a n...

2018-07-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21807 **[Test build #93787 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93787/testReport)** for PR 21807 at commit

[GitHub] spark issue #21807: [SPARK-24536] Validate that limit clause cannot have a n...

2018-07-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21807 **[Test build #93787 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93787/testReport)** for PR 21807 at commit

[GitHub] spark issue #21807: [SPARK-24536] Validate that limit clause cannot have a n...

2018-07-30 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21807 that means Jenkins build was halted unexpectedly. usually unrelated with some changes in a pr. --- - To unsubscribe,

[GitHub] spark issue #21807: [SPARK-24536] Validate that limit clause cannot have a n...

2018-07-30 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21807 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21807: [SPARK-24536] Validate that limit clause cannot have a n...

2018-07-30 Thread mauropalsgraaf
Github user mauropalsgraaf commented on the issue: https://github.com/apache/spark/pull/21807 @hvanhovell Do you know what this unknown error code, -9 means? --- - To unsubscribe, e-mail:

[GitHub] spark issue #21807: [SPARK-24536] Validate that limit clause cannot have a n...

2018-07-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21807 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21807: [SPARK-24536] Validate that limit clause cannot have a n...

2018-07-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21807 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93773/ Test FAILed. ---

[GitHub] spark issue #21807: [SPARK-24536] Validate that limit clause cannot have a n...

2018-07-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21807 **[Test build #93773 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93773/testReport)** for PR 21807 at commit

[GitHub] spark issue #21807: [SPARK-24536] Validate that limit clause cannot have a n...

2018-07-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21807 **[Test build #93773 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93773/testReport)** for PR 21807 at commit

[GitHub] spark issue #21807: [SPARK-24536] Validate that limit clause cannot have a n...

2018-07-29 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21807 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21807: [SPARK-24536] Validate that limit clause cannot have a n...

2018-07-28 Thread mauropalsgraaf
Github user mauropalsgraaf commented on the issue: https://github.com/apache/spark/pull/21807 I've added a test case and now it works properly for the given example in the description. Regarding the comment: "make sure eval is only called once", is this what you ment? ---

[GitHub] spark issue #21807: [SPARK-24536] Validate that limit clause cannot have a n...

2018-07-28 Thread mauropalsgraaf
Github user mauropalsgraaf commented on the issue: https://github.com/apache/spark/pull/21807 Sorry for my absence, will look into it now --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #21807: [SPARK-24536] Validate that limit clause cannot have a n...

2018-07-25 Thread NiharS
Github user NiharS commented on the issue: https://github.com/apache/spark/pull/21807 Hey @mauropalsgraaf just wanted to check in on this. Have you run into any additional issues or have any questions for this fix? ---

[GitHub] spark issue #21807: [SPARK-24536] Validate that limit clause cannot have a n...

2018-07-18 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/21807 @NiharS yeah that makes sense. @mauropalsgraaf we missed this today (sorry about that). Can you add the null check (bonus points if you call `eval()` only once), add a test for this case? ---

[GitHub] spark issue #21807: [SPARK-24536] Validate that limit clause cannot have a n...

2018-07-18 Thread NiharS
Github user NiharS commented on the issue: https://github.com/apache/spark/pull/21807 New to SQL, but it seems like the query `SELECT 1 LIMIT CAST('1' AS INT)` should work, right? I tried both on Spark without to your change and the W3Schools SQL tester and it's

[GitHub] spark issue #21807: [SPARK-24536] Validate that limit clause cannot have a n...

2018-07-18 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/21807 Ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21807: [SPARK-24536] Validate that limit clause cannot have a n...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21807 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21807: [SPARK-24536] Validate that limit clause cannot have a n...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21807 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21807: [SPARK-24536] Validate that limit clause cannot have a n...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21807 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional