[GitHub] spark issue #21816: [SPARK-24794][CORE] Driver launched through rest should ...

2018-10-25 Thread bsikander
Github user bsikander commented on the issue: https://github.com/apache/spark/pull/21816 Thank you. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21816: [SPARK-24794][CORE] Driver launched through rest should ...

2018-10-25 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/21816 Merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21816: [SPARK-24794][CORE] Driver launched through rest should ...

2018-10-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21816 **[Test build #4392 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4392/testReport)** for PR 21816 at commit

[GitHub] spark issue #21816: [SPARK-24794][CORE] Driver launched through rest should ...

2018-10-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21816 **[Test build #4392 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4392/testReport)** for PR 21816 at commit

[GitHub] spark issue #21816: [SPARK-24794][CORE] Driver launched through rest should ...

2018-10-24 Thread bsikander
Github user bsikander commented on the issue: https://github.com/apache/spark/pull/21816 @srowen Can you have another look? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #21816: [SPARK-24794][CORE] Driver launched through rest should ...

2018-10-08 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/21816 Ping @srinathshankar @ericl again for comments? I don't know this well, but seems like a low risk change at worst. --- - To

[GitHub] spark issue #21816: [SPARK-24794][CORE] Driver launched through rest should ...

2018-10-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21816 **[Test build #4357 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4357/testReport)** for PR 21816 at commit

[GitHub] spark issue #21816: [SPARK-24794][CORE] Driver launched through rest should ...

2018-10-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21816 **[Test build #4357 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4357/testReport)** for PR 21816 at commit

[GitHub] spark issue #21816: [SPARK-24794][CORE] Driver launched through rest should ...

2018-10-04 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/21816 Agree, though I'm just going to run them again --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21816: [SPARK-24794][CORE] Driver launched through rest should ...

2018-10-04 Thread bsikander
Github user bsikander commented on the issue: https://github.com/apache/spark/pull/21816 Failing tests don't seem to be related to this change. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #21816: [SPARK-24794][CORE] Driver launched through rest should ...

2018-10-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21816 **[Test build #4356 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4356/testReport)** for PR 21816 at commit

[GitHub] spark issue #21816: [SPARK-24794][CORE] Driver launched through rest should ...

2018-10-02 Thread bsikander
Github user bsikander commented on the issue: https://github.com/apache/spark/pull/21816 >> So is there no behavior change if your master specifies only one master? If user specifies only 1 master then there is no behavioral change. ---

[GitHub] spark issue #21816: [SPARK-24794][CORE] Driver launched through rest should ...

2018-10-01 Thread bsikander
Github user bsikander commented on the issue: https://github.com/apache/spark/pull/21816 @srowen I removed the extra .toString. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21816: [SPARK-24794][CORE] Driver launched through rest should ...

2018-10-01 Thread bsikander
Github user bsikander commented on the issue: https://github.com/apache/spark/pull/21816 @srowen even though it is unlikely but it could happen. I have updated the code. --- - To unsubscribe, e-mail:

[GitHub] spark issue #21816: [SPARK-24794][CORE] Driver launched through rest should ...

2018-09-26 Thread bsikander
Github user bsikander commented on the issue: https://github.com/apache/spark/pull/21816 >> What might break if we make this change? I think that's what any other reviewer cares abou To the best of my knowledge. Nothing should break. ---

[GitHub] spark issue #21816: [SPARK-24794][CORE] Driver launched through rest should ...

2018-09-25 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/21816 cc @srinathshankar @ericl --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #21816: [SPARK-24794][CORE] Driver launched through rest should ...

2018-09-24 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/21816 That could help, yes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21816: [SPARK-24794][CORE] Driver launched through rest should ...

2018-09-24 Thread bsikander
Github user bsikander commented on the issue: https://github.com/apache/spark/pull/21816 @vanzin ok, how can I find the right reviewer for this change? Posting on dev mailing list? --- - To unsubscribe, e-mail:

[GitHub] spark issue #21816: [SPARK-24794][CORE] Driver launched through rest should ...

2018-09-24 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/21816 I know you pinged me, but I'm really not familiar with how Spark standalone is deployed, and I don't even know who's maintaining this code these days... ---

[GitHub] spark issue #21816: [SPARK-24794][CORE] Driver launched through rest should ...

2018-09-22 Thread bsikander
Github user bsikander commented on the issue: https://github.com/apache/spark/pull/21816 Could some please have a look at this? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21816: [SPARK-24794][CORE] Driver launched through rest should ...

2018-09-08 Thread bsikander
Github user bsikander commented on the issue: https://github.com/apache/spark/pull/21816 could someone please have a look at this change? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #21816: [SPARK-24794][CORE] Driver launched through rest should ...

2018-08-26 Thread bsikander
Github user bsikander commented on the issue: https://github.com/apache/spark/pull/21816 Sorry for dropping message again, but could someone please have a look at this change. This is a problem that I am having constantly and a validation from senior committers will be really

[GitHub] spark issue #21816: [SPARK-24794][CORE] Driver launched through rest should ...

2018-08-16 Thread bsikander
Github user bsikander commented on the issue: https://github.com/apache/spark/pull/21816 @holdenk somehow, Jenkins didn't execute the tests. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #21816: [SPARK-24794][CORE] Driver launched through rest should ...

2018-08-03 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/21816 Jenkins OK to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21816: [SPARK-24794][CORE] Driver launched through rest should ...

2018-07-27 Thread bsikander
Github user bsikander commented on the issue: https://github.com/apache/spark/pull/21816 @vanzin Could you please have a look on this change? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #21816: [SPARK-24794][CORE] Driver launched through rest should ...

2018-07-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21816 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21816: [SPARK-24794][CORE] Driver launched through rest should ...

2018-07-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21816 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21816: [SPARK-24794][CORE] Driver launched through rest should ...

2018-07-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21816 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional