Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21826
**[Test build #93596 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93596/testReport)**
for PR 21826 at commit
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/21826
No we can't because you can still use string concat in filters, e.g.
colA || colB == "ab"
What is "||" here?
---
Github user httfighter commented on the issue:
https://github.com/apache/spark/pull/21826
I have a suggestion that I don't know if it is reasonable.
In our spark, since we already support â||â as a string concatenation
function, I don't know if we can make such an improvement.
Github user httfighter commented on the issue:
https://github.com/apache/spark/pull/21826
I did the following tests in mysql.
mysql> select "abc" || "def";
++
| "abc" || "def" |
++
| 0
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/21826
I am not sure there is much to do here. `OR` is the standard syntax for or,
and `||` is pretty common syntax for string concatenation. Removing `||` breaks
binary compatibility and also makes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21826
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21826
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93378/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21826
**[Test build #93378 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93378/testReport)**
for PR 21826 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21826
**[Test build #93378 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93378/testReport)**
for PR 21826 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21826
test this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21826
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21826
Looks it's gonna make a compilation failure and I see potential references
referring this field. @httfighter, I think manual build and tests are required.
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21826
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/21826
cc @gatorsmile @cloud-fan @HyukjinKwon this is a good thing to do?
---
-
To unsubscribe, e-mail:
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/21826
Jenkins, test this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21826
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21826
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21826
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
18 matches
Mail list logo
