[GitHub] spark issue #21897: [minor] Improve documentation for HiveStringType's

2018-07-27 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/21897 Thanks! Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21897: [minor] Improve documentation for HiveStringType's

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21897 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93684/ Test PASSed. ---

[GitHub] spark issue #21897: [minor] Improve documentation for HiveStringType's

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21897 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21897: [minor] Improve documentation for HiveStringType's

2018-07-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21897 **[Test build #93684 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93684/testReport)** for PR 21897 at commit

[GitHub] spark issue #21897: [minor] Improve documentation for HiveStringType's

2018-07-27 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/21897 @rxin no, they should not have been public. IMO we should just hide them for 3.0. --- - To unsubscribe, e-mail:

[GitHub] spark issue #21897: [minor] Improve documentation for HiveStringType's

2018-07-27 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/21897 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21897: [minor] Improve documentation for HiveStringType's

2018-07-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21897 **[Test build #93684 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93684/testReport)** for PR 21897 at commit

[GitHub] spark issue #21897: [minor] Improve documentation for HiveStringType's

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21897 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21897: [minor] Improve documentation for HiveStringType's

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21897 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #21897: [minor] Improve documentation for HiveStringType's

2018-07-27 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/21897 cc @gatorsmile cc @hvanhovell why did we expose these types as public Scala APIs? I feel they should not have been public. If they are public, we should have more generic VarcharType and