[GitHub] spark issue #21901: [SPARK-24950][SQL] DateTimeUtilsSuite daysToMillis and m...

2018-07-28 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/21901 Merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21901: [SPARK-24950][SQL] DateTimeUtilsSuite daysToMillis and m...

2018-07-27 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/21901 LGTM, too --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21901: [SPARK-24950][SQL] DateTimeUtilsSuite daysToMillis and m...

2018-07-27 Thread shaneknapp
Github user shaneknapp commented on the issue: https://github.com/apache/spark/pull/21901 the spark-master-test-sbt build failed on ubuntu, but the the improtant bit is that the DateTimeUtilsSuite tests passed! i think this PR should be g2g for merging in to master. thanks

[GitHub] spark issue #21901: [SPARK-24950][SQL] DateTimeUtilsSuite daysToMillis and m...

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21901 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93697/ Test PASSed. ---

[GitHub] spark issue #21901: [SPARK-24950][SQL] DateTimeUtilsSuite daysToMillis and m...

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21901 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21901: [SPARK-24950][SQL] DateTimeUtilsSuite daysToMillis and m...

2018-07-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21901 **[Test build #93697 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93697/testReport)** for PR 21901 at commit

[GitHub] spark issue #21901: [SPARK-24950][SQL] DateTimeUtilsSuite daysToMillis and m...

2018-07-27 Thread shaneknapp
Github user shaneknapp commented on the issue: https://github.com/apache/spark/pull/21901 let's hold off on merging until i confirm that this works on the latest java release on ubuntu-testing. --- - To

[GitHub] spark issue #21901: [SPARK-24950][SQL] DateTimeUtilsSuite daysToMillis and m...

2018-07-27 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/21901 Oops I made https://github.com/apache/spark/pull/21903 without looking at this; I had just disabled the test but I think I like this approach better. ---

[GitHub] spark issue #21901: [SPARK-24950][SQL] DateTimeUtilsSuite daysToMillis and m...

2018-07-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21901 **[Test build #93697 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93697/testReport)** for PR 21901 at commit

[GitHub] spark issue #21901: [SPARK-24950][SQL] DateTimeUtilsSuite daysToMillis and m...

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21901 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21901: [SPARK-24950][SQL] DateTimeUtilsSuite daysToMillis and m...

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21901 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #21901: [SPARK-24950][SQL] DateTimeUtilsSuite daysToMillis and m...

2018-07-27 Thread shaneknapp
Github user shaneknapp commented on the issue: https://github.com/apache/spark/pull/21901 apparently i got removed from the PRB admin list... and i've added myself back and this should test now. :) --- - To

[GitHub] spark issue #21901: [SPARK-24950][SQL] DateTimeUtilsSuite daysToMillis and m...

2018-07-27 Thread shaneknapp
Github user shaneknapp commented on the issue: https://github.com/apache/spark/pull/21901 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21901: [SPARK-24950][SQL] DateTimeUtilsSuite daysToMillis and m...

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21901 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21901: [SPARK-24950][SQL] DateTimeUtilsSuite daysToMillis and m...

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21901 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #21901: [SPARK-24950][SQL] DateTimeUtilsSuite daysToMillis and m...

2018-07-27 Thread shaneknapp
Github user shaneknapp commented on the issue: https://github.com/apache/spark/pull/21901 test this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21901: [SPARK-24950][SQL] DateTimeUtilsSuite daysToMillis and m...

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21901 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21901: [SPARK-24950][SQL] DateTimeUtilsSuite daysToMillis and m...

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21901 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #21901: [SPARK-24950][SQL] DateTimeUtilsSuite daysToMillis and m...

2018-07-27 Thread shaneknapp
Github user shaneknapp commented on the issue: https://github.com/apache/spark/pull/21901 testing this change manually on the ubuntu-testing worker: https://amplab.cs.berkeley.edu/jenkins/job/spark-master-test-sbt-hadoop-2.6-ubuntu-test/878/ ---

[GitHub] spark issue #21901: [SPARK-24950][SQL] DateTimeUtilsSuite daysToMillis and m...

2018-07-27 Thread shaneknapp
Github user shaneknapp commented on the issue: https://github.com/apache/spark/pull/21901 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21901: [SPARK-24950][SQL] DateTimeUtilsSuite daysToMillis and m...

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21901 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21901: [SPARK-24950][SQL] DateTimeUtilsSuite daysToMillis and m...

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21901 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #21901: [SPARK-24950][SQL] DateTimeUtilsSuite daysToMillis and m...

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21901 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21901: [SPARK-24950][SQL] DateTimeUtilsSuite daysToMillis and m...

2018-07-27 Thread shaneknapp
Github user shaneknapp commented on the issue: https://github.com/apache/spark/pull/21901 this is great, but i will have to manually test this on our ubuntu testing worker. please do not merge until i confirm it works. ---

[GitHub] spark issue #21901: [SPARK-24950][SQL] DateTimeUtilsSuite daysToMillis and m...

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21901 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21901: [SPARK-24950][SQL] DateTimeUtilsSuite daysToMillis and m...

2018-07-27 Thread shaneknapp
Github user shaneknapp commented on the issue: https://github.com/apache/spark/pull/21901 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21901: [SPARK-24950][SQL] DateTimeUtilsSuite daysToMillis and m...

2018-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21901 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional